Return all failures #136680
Draft
Return all failures #136680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idegtiarenko
commented
Oct 16, 2025
| var cause = failure.getException().getCause(); | ||
| assertThat(cause, isA(IndexNotFoundException.class)); | ||
| assertThat(cause.getMessage(), equalTo("no such index [no-such-index]")); | ||
| assertThat(failure.getIndices(), arrayContaining("remote_cluster:no-such-index")); // this contains actual remote |
Contributor
Author
There was a problem hiding this comment.
It would be nice if we could adapt it to:
- contain all indices not found failures
- be able to report indices not found and security exceptions at once
- collect unknown remotes exceptions (so that a caller could handle them according to skip unavailable)
# Conflicts: # server/src/internalClusterTest/java/org/elasticsearch/search/fieldcaps/CCSFieldCapabilitiesIT.java # server/src/main/java/org/elasticsearch/action/fieldcaps/TransportFieldCapabilitiesAction.java
Member
|
@idegtiarenko do we still need this or can be derived from the resolvedLocally and resolvedRemotely data structures? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a FC flag requiring it to return all failures.
It is required in order to create a summary of multiple errors or in order to handle partial results.