-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Disable cross-cluster functionality for _fleet/_fleet_msearch
#136703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable cross-cluster functionality for _fleet/_fleet_msearch
#136703
Conversation
|
Hi @pawankartik-elastic, I've created a changelog YAML for you. Note that since this PR is labelled |
|
This check applies irrespective of whether checkpoints are specified or not. I'll seek a review from the Fleet team to ensure this is appropriate. If not, I'll modify it to act similarly to the indices length check. |
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
|
@cmacknz Craig, I could use your review. |
cmacknz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
piergm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for working on this @pawankartik-elastic
…tic#136703) Disable cross-cluster functionality for `_fleet/_fleet_msearch`
…tic#136703) Disable cross-cluster functionality for `_fleet/_fleet_msearch`
As done here: #136039, I'm also disabling cross-cluster functionality for the Fleet multisearch endpoint. This, too, is covered by the previously approved blanket-breaking change proposal.
Note: This endpoint prevents multiple indices only when checkpoints are specified. However, the docs don't seem to say any such thing:
It also says:
But
_fleet/_fleet_searchdoes not depend on this param to prevent multiple indices. I'll recheck this point and update this PR with the changes and an explicit comment.