Skip to content

Conversation

@pawankartik-elastic
Copy link
Contributor

As done here: #136039, I'm also disabling cross-cluster functionality for the Fleet multisearch endpoint. This, too, is covered by the previously approved blanket-breaking change proposal.

Note: This endpoint prevents multiple indices only when checkpoints are specified. However, the docs don't seem to say any such thing:

index string Required
A single target to search. If the target is an index alias, it must resolve to a single index.

It also says:

However, similar to the Fleet search API, it supports the wait_for_checkpoints parameter.

But _fleet/_fleet_search does not depend on this param to prevent multiple indices. I'll recheck this point and update this PR with the changes and an explicit comment.

@pawankartik-elastic pawankartik-elastic added >breaking Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch :Search Foundations/CCS labels Oct 16, 2025
@elasticsearchmachine
Copy link
Collaborator

Hi @pawankartik-elastic, I've created a changelog YAML for you. Note that since this PR is labelled >breaking, you need to update the changelog YAML to fill out the extended information sections.

@pawankartik-elastic
Copy link
Contributor Author

pawankartik-elastic commented Oct 16, 2025

This check applies irrespective of whether checkpoints are specified or not. I'll seek a review from the Fleet team to ensure this is appropriate. If not, I'll modify it to act similarly to the indices length check.

@pawankartik-elastic pawankartik-elastic marked this pull request as ready for review October 17, 2025 13:42
@pawankartik-elastic pawankartik-elastic requested a review from a team as a code owner October 17, 2025 13:42
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

@pawankartik-elastic
Copy link
Contributor Author

@cmacknz Craig, I could use your review.

Copy link
Member

@cmacknz cmacknz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@piergm piergm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for working on this @pawankartik-elastic

@pawankartik-elastic pawankartik-elastic merged commit e88cb33 into elastic:main Oct 20, 2025
34 checks passed
@pawankartik-elastic pawankartik-elastic deleted the pkar/fleet-msearch-disable-cross-cluster branch October 20, 2025 08:44
chrisparrinello pushed a commit to chrisparrinello/elasticsearch that referenced this pull request Oct 24, 2025
…tic#136703)

Disable cross-cluster functionality for `_fleet/_fleet_msearch`
fzowl pushed a commit to voyage-ai/elasticsearch that referenced this pull request Nov 3, 2025
…tic#136703)

Disable cross-cluster functionality for `_fleet/_fleet_msearch`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>breaking :Search Foundations/CCS Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants