Expose masterNodeTimeout to feature state reset impls
#136802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resetting a feature state involves several master-node actions. Today these actions cannot access the timeout specified in the original REST request, so they must invent their own timeouts. In practice they all use the (trappy) default timeout of 30s, which may be too short for some situations. This commit adds the plumbing needed to pass the timeout from the REST request down to a place where it can be accessed by the individual implementations, and applies it to the delete-index requests. Relates elastic#107984
DaveCTurner
added
>non-issue
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
chrisparrinello
pushed a commit
to chrisparrinello/elasticsearch
that referenced
this pull request
Oct 24, 2025
Resetting a feature state involves several master-node actions. Today these actions cannot access the timeout specified in the original REST request, so they must invent their own timeouts. In practice they all use the (trappy) default timeout of 30s, which may be too short for some situations. This commit adds the plumbing needed to pass the timeout from the REST request down to a place where it can be accessed by the individual implementations, and applies it to the delete-index requests. Relates elastic#107984
fzowl
pushed a commit
to voyage-ai/elasticsearch
that referenced
this pull request
Nov 3, 2025
Resetting a feature state involves several master-node actions. Today these actions cannot access the timeout specified in the original REST request, so they must invent their own timeouts. In practice they all use the (trappy) default timeout of 30s, which may be too short for some situations. This commit adds the plumbing needed to pass the timeout from the REST request down to a place where it can be accessed by the individual implementations, and applies it to the delete-index requests. Relates elastic#107984
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resetting a feature state involves several master-node actions. Today
these actions cannot access the timeout specified in the original REST
request, so they must invent their own timeouts. In practice they all
use the (trappy) default timeout of 30s, which may be too short for some
situations. This commit adds the plumbing needed to pass the timeout
from the REST request down to a place where it can be accessed by the
individual implementations, and applies it to the delete-index requests.
Relates #107984