Clean up node start order #136966
Merged
Clean up node start order #136966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some service starts were added after http start, but these should all be before starting http. In general nothing should be added after http start. This commit moves the offending service starts earlier during startup, and adds a loud comment to deter future such additions.
rjernst
added
>refactoring
:Core/Infra/Node Lifecycle
elasticsearchmachine
added
Team:Core/Infra
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
mark-vieira
approved these changes
Oct 22, 2025
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
fzowl
pushed a commit
to voyage-ai/elasticsearch
that referenced
this pull request
Nov 3, 2025
Some service starts were added after http start, but these should all be before starting http. In general nothing should be added after http start. This commit moves the offending service starts earlier during startup, and adds a loud comment to deter future such additions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some service starts were added after http start, but these should all be before starting http. In general nothing should be added after http start. This commit moves the offending service starts earlier during startup, and adds a loud comment to deter future such additions.