Sets CPSMode(true) only if CPS is enabled and searchRequest is allowCrossProject #137011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piergm
requested review from
pawankartik-elastic and
ywangd
and removed request for
ywangd
elasticsearchmachine
added
needs:triage
piergm
added
>non-issue
:Search/Search
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
elasticsearchmachine
removed
the
needs:triage
pawankartik-elastic
approved these changes
Oct 23, 2025
elasticsearchmachine
added
the
serverless-linked
ywangd
approved these changes
Oct 23, 2025
Member
ywangd
left a comment
ywangd
left a comment
There was a problem hiding this comment.
LGTM
I assume this change is because we have completed the demo so that SearchRequest is reverted to have allowsCrossProject == false and hence should not have the IndicesOptions set (I also noticed the search test in CrossProjectSearchIT is removed as well).
Member
Author
Yes, exactly that :D sorry for not adding more context in the PR 😄 |
fzowl
pushed a commit
to voyage-ai/elasticsearch
that referenced
this pull request
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.