Unmute flaky csv-spec tests with more logging on warnings context #137089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests do not reproduce, even with reported random seeds. We are unmuting them in the hope that the additional logging will bring some clarity to the situation under which they fail.
craigtaverner
added
>test
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
This was referenced Oct 24, 2025
[CI] GenerativeForkIT test {csv-spec:fuse.FuseWithRowLinearAndMultiValueScoreColumn} failing
#136068
Closed
craigtaverner
commented
Oct 24, 2025
| contextBuilder.append("...(truncated)"); | ||
| } | ||
| contextBuilder.append("\n"); | ||
| return contextBuilder.toString(); |
There was a problem hiding this comment.
Just in case you're wondering, I've tested this multiple times by deliberately messing with the tests expected warnings, and I do see meaningful stuff being printed here in the error messages. Whether that will clarify the flakiness or not is yet to be seen.
cimequinox
approved these changes
Oct 24, 2025
craigtaverner
added
v9.2.0
auto-backport
💔 Backport failed
You can use sqren/backport to manually backport by running |
craigtaverner
added a commit
to craigtaverner/elasticsearch
that referenced
this pull request
Oct 24, 2025
…astic#137089) These tests do not reproduce, even with reported random seeds. We are unmuting them in the hope that the additional logging will bring some clarity to the situation under which they fail.
|
Manual backport at #137107 |
fzowl
pushed a commit
to voyage-ai/elasticsearch
that referenced
this pull request
Nov 3, 2025
…astic#137089) These tests do not reproduce, even with reported random seeds. We are unmuting them in the hope that the additional logging will bring some clarity to the situation under which they fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests do not reproduce, even with reported random seeds. We are unmuting them in the hope that the additional logging will bring some clarity to the situations under which they fail.
Of note is that there are 186 tests that have warnings specified, but only 8 issues reported grouped into the following test classes:
Five of the eight were related to parsing invalid geospatial types, the other three were change_point, fuse and space-negative.
Six of the eight were reported on main:
Fixes #136249
Fixes #135455
Fixes #134635
Fixes #134254
Fixes #134104
Fixes #133334
Two issues were only muted on 9.2, so we should unmute in the backport: #136285 and #136068