Skip to content

ESQL: Fixes ValuesTests OOM #137092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ncordon merged 6 commits into from
Oct 24, 2025
Merged

ESQL: Fixes ValuesTests OOM #137092

ncordon merged 6 commits into from
Oct 24, 2025

Conversation

@ncordon
Copy link
Contributor

@ncordon ncordon commented Oct 24, 2025 •
edited
Loading

Closes #128649
Closes #128709

This was done for 9.0 onwards here: #124685

@ncordon ncordon added >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) auto-backport Automatically create backport pull requests when merged :Analytics/ES|QL AKA ESQL Team:ES|QL v9.2.1 v9.3.0 v8.19.7 v9.1.7 labels Oct 24, 2025
@ncordon ncordon changed the title ESQL: Fixes a test OOM ESQL: Fixes ValuesTests OOM Oct 24, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Oct 24, 2025

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Oct 24, 2025

Hi @ncordon, I've created a changelog YAML for you.

craigtaverner
craigtaverner requested changes Oct 24, 2025
View reviewed changes
Copy link
Contributor

@craigtaverner craigtaverner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a bug-fix, but a change to tests. So the labels should be >test and not >bug, and there should be no changelog yaml file.

@ncordon ncordon added >test Issues or PRs that are addressing/adding tests and removed >bug labels Oct 24, 2025
@ncordon ncordon removed the auto-backport Automatically create backport pull requests when merged label Oct 24, 2025
craigtaverner
craigtaverner approved these changes Oct 24, 2025
View reviewed changes
Copy link
Contributor

@craigtaverner craigtaverner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ncordon ncordon merged commit 3cceb31 into elastic:8.19 Oct 24, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@craigtaverner craigtaverner craigtaverner approved these changes

@idegtiarenko idegtiarenko idegtiarenko approved these changes

Assignees

No one assigned

Labels

:Analytics/ES|QL AKA ESQL Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:ES|QL >test Issues or PRs that are addressing/adding tests v8.19.7

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ncordon @elasticsearchmachine @craigtaverner @idegtiarenko