Skip to content

Conversation

@pabloem
Copy link
Contributor

@pabloem pabloem commented Oct 25, 2025

  • Implements a one-pass simple linear regression algorithm for time-series (x-long, y-double)
  • Implements per-type specializations that simply cast to double.
  • Returns the slope of the linreg as the derivative

Implementation of https://prometheus.io/docs/prometheus/latest/querying/functions/#deriv

@pabloem pabloem marked this pull request as ready for review October 27, 2025 18:26
@pabloem pabloem changed the title [wip] Initial steps of implementing Derivative using linear regression Implementing Derivative using linear regression Oct 27, 2025
@pabloem pabloem requested a review from dnhatn October 27, 2025 18:26
@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label Oct 27, 2025
@pabloem pabloem added >feature :StorageEngine/TSDB You know, for Metrics Team:StorageEngine and removed needs:triage Requires assignment of a team area label labels Oct 27, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pabloem Sorry for the delay. I left some comments. We can zoom if needed.

@dnhatn dnhatn self-requested a review November 7, 2025 18:04
@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

@github-actions
Copy link
Contributor

ℹ️ Important: Docs version tagging

👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version.

We use applies_to tags to mark version-specific features and changes.

Expand for a quick overview

When to use applies_to tags:

✅ At the page level to indicate which products/deployments the content applies to (mandatory)
✅ When features change state (e.g. preview, ga) in a specific version
✅ When availability differs across deployments and environments

What NOT to do:

❌ Don't remove or replace information that applies to an older version
❌ Don't add new information that applies to a specific version without an applies_to tag
❌ Don't forget that applies_to tags can be used at the page, section, and inline level

🤔 Need help?

Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some comments, but the PR looks great. Thanks Pablo!

@dnhatn dnhatn self-requested a review November 20, 2025 02:54
Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for all iterations, @pabloem!

@pabloem pabloem enabled auto-merge (squash) November 20, 2025 05:09
@pabloem pabloem merged commit ab7fcd4 into elastic:main Nov 20, 2025
34 checks passed
@pabloem pabloem deleted the pem-deriv-wip branch November 20, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants