-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Implementing Derivative using linear regression #137142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1c00f5f to
1e73748
Compare
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
49aad40 to
87eeb7b
Compare
dnhatn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pabloem Sorry for the delay. I left some comments. We can zoom if needed.
...gin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/aggregate/Deriv.java
Outdated
Show resolved
Hide resolved
...gin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/aggregate/Deriv.java
Outdated
Show resolved
Hide resolved
...gin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/aggregate/Deriv.java
Show resolved
Hide resolved
...gin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/aggregate/Deriv.java
Outdated
Show resolved
Hide resolved
...ain/java/org/elasticsearch/compute/aggregation/SimpleLinearRegressionWithTimeseries.java.new
Outdated
Show resolved
Hide resolved
...rc/main/java/org/elasticsearch/compute/aggregation/SimpleLinearRegressionWithTimeseries.java
Outdated
Show resolved
Hide resolved
.../compute/src/main/java/org/elasticsearch/compute/aggregation/GroupingAggregatorFunction.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/elasticsearch/compute/aggregation/X-DerivGroupingAggregatorFunction.java.st
Outdated
Show resolved
Hide resolved
ℹ️ Important: Docs version tagging👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version. We use applies_to tags to mark version-specific features and changes. Expand for a quick overviewWhen to use applies_to tags:✅ At the page level to indicate which products/deployments the content applies to (mandatory) What NOT to do:❌ Don't remove or replace information that applies to an older version 🤔 Need help?
|
x-pack/plugin/esql/qa/testFixtures/src/main/resources/k8s-timeseries.csv-spec
Outdated
Show resolved
Hide resolved
dnhatn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left some comments, but the PR looks great. Thanks Pablo!
.../compute/src/main/java/org/elasticsearch/compute/aggregation/GroupingAggregatorFunction.java
Outdated
Show resolved
Hide resolved
...gin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/aggregate/Deriv.java
Outdated
Show resolved
Hide resolved
...sql/src/main/java/org/elasticsearch/xpack/esql/expression/function/EsqlFunctionRegistry.java
Outdated
Show resolved
Hide resolved
...gin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/aggregate/Deriv.java
Outdated
Show resolved
Hide resolved
...gin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/aggregate/Deriv.java
Outdated
Show resolved
Hide resolved
dnhatn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for all iterations, @pabloem!
Implementation of https://prometheus.io/docs/prometheus/latest/querying/functions/#deriv