Refactor some allocation explain / move decision code #137400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiannaHohensee
added
>non-issue
:Distributed Coordination/Allocation
Collaborator
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
Contributor
Author
|
Working through adding NOT_PREFERRED to allocation explain and these refactors help me reason about it better. |
ywangd
approved these changes
Oct 31, 2025
| */ | ||
| public boolean cannotRemain() { | ||
| checkDecisionState(); | ||
| return canRemainDecision.type() != Type.YES; |
Member
There was a problem hiding this comment.
Can we either assert the boolean result here is the opposite to canRemain() or delegate it to canRemain(), i.e. return canRemain() == false? It would be nice to prevent these methods to go out of sync for any reason.
Contributor
Author
There was a problem hiding this comment.
I hesitate because they may not always be opposites: NOT_PREFERRED makes the ideas muddier. But that's a future 'if". I'll go ahead with canRemain() == false since that's how it works now 👍
DiannaHohensee
added
the
auto-merge-without-approval
Kubik42
pushed a commit
to Kubik42/elasticsearch
that referenced
this pull request
Nov 10, 2025
Add `MoveDecision#cannotRemain()` to replace the numerous `canRemain() == false` checks Rename `Balancer#decideRebalance()` to `Balancer#explainRebalanceDecision()` Rename a `Decision canRemain` variable to `Decision canRemainDecision` so it doesn't sound like a boolean Relates ES-12833
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
MoveDecision#cannotRemain()to replacethe numerous
canRemain() == falsechecksRename
Balancer#decideRebalance()toBalancer#explainRebalanceDecision()Rename a
Decision canRemainvariable toDecision canRemainDecisionso it doesn'tsound like a boolean
Relates ES-12833