[ML] Fix flaky ForecastIT#testOverflowToDisk #137452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Added logic to wait for forecast documents to exist in non-terminal states (SCHEDULED, STARTED) before checking for FINISHED status. Included index refresh to ensure visibility of recently indexed forecast stats documents.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a flaky test (ForecastIT#testOverflowToDisk) by addressing race conditions in forecast status verification. The fix ensures the forecast document is visible and properly tracked through its state transitions before asserting completion.
Key Changes:
- Modified
waitForecastToFinishto perform a two-stage wait: first for the forecast to reach any non-terminal state (SCHEDULED/STARTED/FINISHED), then specifically for FINISHED status - Added index refresh in
waitForecastStatusto ensure recently indexed forecast documents are visible before status checks
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+249
to
+259
| int timeoutSeconds = inFipsJvm() ? 300 : 90; | ||
| // First wait for the forecast document to exist and be in a non-terminal state | ||
| // This handles the race condition where the document may be SCHEDULED or STARTED initially | ||
| waitForecastStatus( | ||
| timeoutSeconds, | ||
| jobId, | ||
| forecastId, | ||
| ForecastRequestStats.ForecastRequestStatus.SCHEDULED, | ||
| ForecastRequestStats.ForecastRequestStatus.STARTED, | ||
| ForecastRequestStats.ForecastRequestStatus.FINISHED | ||
| ); |
There was a problem hiding this comment.
Corrected spelling of 'flacky' to 'flaky' in the PR title.
valeriy42
changed the title
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's going on:
Race condition:
Hence, this PR mitigates the possible race condition by doing two things:
Fixes #117740