-
Notifications
You must be signed in to change notification settings - Fork 25.6k
T digest field mapper #137546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
not-napoleon
merged 18 commits into
elastic:main
from
not-napoleon:t-digest-field-mapper
Nov 6, 2025
Merged
T digest field mapper #137546
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
bde49a6
initial fork of histogram mapper
not-napoleon 3e3f316
fix field names in tests
not-napoleon 61526e7
tests for compression behavior
not-napoleon 3922a95
better test failure message
not-napoleon ef6054a
add control parameters
not-napoleon bb80bda
update tests for the new parameters
not-napoleon b7abc0b
feature flag
not-napoleon 88165ac
remove nocommit
not-napoleon 817e54d
remove nocommits
not-napoleon 46b09fc
missed a rename
not-napoleon 39a0917
Merge branch 'main' into t-digest-field-mapper
not-napoleon 837e922
integrate upstream changes
not-napoleon 0c87d60
include value in error message
not-napoleon 5d521a0
typos and renaming
not-napoleon dc5e5f4
values -> centroids
not-napoleon ff3f54b
Merge remote-tracking branch 'refs/remotes/not-napoleon/t-digest-fiel…
not-napoleon fbe64a9
fix test
not-napoleon 8e76fa2
Merge branch 'main' into t-digest-field-mapper
not-napoleon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -42,7 +42,7 @@ public class TDigestState implements Releasable, Accountable { | |
| private final TDigest tdigest; | ||
|
|
||
| // Supported tdigest types. | ||
| protected enum Type { | ||
| public enum Type { | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Expanding the visibility here so we can use it as a parameter to the field. |
||
| HYBRID, | ||
| AVL_TREE, | ||
| MERGING, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is tangential to the main point of this PR, but part of the exploratory work and seems like a reasonable test in general.