Skip to content

[9.2] Fix GeoIpDownloaderIT.testInvalidTimestamp (#137663) #137844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2025
Merged

[9.2] Fix GeoIpDownloaderIT.testInvalidTimestamp (#137663) #137844

merged 1 commit into from
Nov 10, 2025
+54 −18

Conversation

@nielsbauman
Copy link
Contributor

@nielsbauman nielsbauman commented Nov 10, 2025

Backports the following commits to 9.2:

@nielsbauman
Fix GeoIpDownloaderIT.testInvalidTimestamp (elastic#137663)
da7fd46 
The GeoIP expiration logic assumes that the md5 hashes of the databases change over time, as it deletes all database chunks from the .geoip_databases index. If the hashes do not change, no new database chunks are indexed and so the ingest nodes fail to download the databases as there are no chunks to download.
In this test suite, we don't have a way to change the database files served by the fixture, and thus change their md5 hashes.
Since we assume that in a real-world scenario the database files change over time, we are ok with skipping this part of the test.

See elastic#128284 (comment) for a detailed investigation.

Closes elastic#128284
@nielsbauman nielsbauman added :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >test Issues or PRs that are addressing/adding tests auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Data Management Meta label for data/management team labels Nov 10, 2025
@elasticsearchmachine elasticsearchmachine mentioned this pull request Nov 10, 2025
Merged
@elasticsearchmachine elasticsearchmachine merged commit d6604f1 into elastic:9.2 Nov 10, 2025
34 checks passed
@nielsbauman nielsbauman deleted the backport/9.2/pr-137663 branch November 10, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP Team:Data Management Meta label for data/management team >test Issues or PRs that are addressing/adding tests v9.2.2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nielsbauman @elasticsearchmachine