-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[ML] Add validation for updating num_threads #138122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
num_threads cannot be updated and should result in a validation error Fix elastic#137129
|
Hi @prwhelan, I've created a changelog YAML for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds validation to prevent updating the num_threads parameter in Elasticsearch internal service settings, addressing issue #137129. When users attempt to update this parameter, they will now receive a clear validation error instead of potentially experiencing undefined behavior.
Key changes:
- Added validation logic to reject
num_threadsupdates in service settings - Added test coverage to verify the validation error is thrown correctly
- Added changelog entry documenting this bug fix
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ElasticsearchInternalServiceSettings.java | Added validation check to throw ValidationException when num_threads update is attempted |
| ElasticsearchInternalServiceTests.java | Added test case to verify num_threads update validation |
| docs/changelog/138122.yaml | Added changelog entry for this bug fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Pinging @elastic/ml-core (Team:ML) |
💔 Backport failed
You can use sqren/backport to manually backport by running |
num_threads cannot be updated and should result in a validation error Fix elastic#137129
num_threads cannot be updated and should result in a validation error
Fix #137129