[GPU] test FIX: return builtin CuVSProvider when mock is null in internalClusterTests #138155
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldematte
added
>test
elasticsearchmachine
added
v9.3.0
v9.2.2
Team:Search Relevance
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
mayya-sharipova
approved these changes
Nov 17, 2025
Collaborator
💚 Backport successful
|
ldematte
added a commit
to ldematte/elasticsearch
that referenced
this pull request
Nov 18, 2025
…Tests (elastic#138155) In elastic#137126 we refactored GPUSupport to use static initialization. Some IT tests were fixed to support this, but we did not notice that GPUIndexIT needed attention too. GPUIndexIT uses the real (builtin) CuVSProvider, and thus does not need to provide a mock. This PR changes the Test CuVSProvider to "bypass" itself when we do no specify a mock, so that in those cases we use the builtin provider.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 18, 2025
…Tests (#138155) (#138215) In #137126 we refactored GPUSupport to use static initialization. Some IT tests were fixed to support this, but we did not notice that GPUIndexIT needed attention too. GPUIndexIT uses the real (builtin) CuVSProvider, and thus does not need to provide a mock. This PR changes the Test CuVSProvider to "bypass" itself when we do no specify a mock, so that in those cases we use the builtin provider.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #137126 we refactored GPUSupport to use static initialization. Some IT tests were fixed to support this, but we did not notice that GPUIndexIT needed attention too.
GPUIndexIT uses the real (builtin) CuVSProvider, and thus does not need to provide a mock.
This PR changes the Test CuVSProvider to "bypass" itself when we do no specify a mock, so that in those cases we use the builtin provider.