Ensure IndicesOptions are mutated for GetInferenceFieldsActionRequest… #138163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Tests When `IndicesOptions` are mutated, we may produce `null`. The request constructor sets indices options to the default ones when the argument is `null`. Thus, if the original instance had the default `IndicesOptions` to begin with, we will end up with a mutation that is identical. This fixes this by generating a new random `IndicesOptions` object in the case above. Closed elastic#138134
dimitris-athanasiou
added
>test
Collaborator
|
Pinging @elastic/search-relevance (Team:Search - Relevance) |
elasticsearchmachine
added
the
Team:Search - Relevance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Tests
When
IndicesOptionsare mutated, we may producenull. The request constructor sets indices options to the default ones when the argument isnull. Thus, if the original instance had the defaultIndicesOptionsto begin with, we will end up with a mutation that is identical.This fixes this by generating a new random
IndicesOptionsobject in the case above.Closed #138134