Fix DataStreamLifecycleDownsampleIT.testUpdateDownsampleSamplingMode
#138174
+1
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was clear from failed tests that DLM was still progressing when the timeout of 10s was reached. Since DLM works on a poll interval (set to 1s in these tests), there's not much we can do to speed up the test. Therefore, we simply bump the timeout from 10s to 30s. This should give DLM enough time to complete the downsampling mode change. Note that `safeAwait` uses a timeout of 10s and `awaitClusterState` uses a timeout of 30s; that's why there's no explicit timeout change. Fixes elastic#138135
elasticsearchmachine
added
needs:triage
nielsbauman
added
>test
elasticsearchmachine
added
Team:Data Management
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
gmarouli
approved these changes
Nov 18, 2025
Contributor
gmarouli
left a comment
gmarouli
left a comment
There was a problem hiding this comment.
LGTM, thank you @nielsbauman
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was clear from failed tests that DLM was still progressing when the timeout of 10s was reached. Since DLM works on a poll interval (set to 1s in these tests), there's not much we can do to speed up the test. Therefore, we simply bump the timeout from 10s to 30s. This should give DLM enough time to complete the downsampling mode change.
Note that
safeAwaituses a timeout of 10s andawaitClusterStateuses a timeout of 30s; that's why there's no explicit timeout change.Fixes #138135