[9.2] Fix default value for some settings when filtered (#137652) #138194
+96
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some settings (such as index.mapping.total_fields. ignore_dynamic_beyond_limit) rely on the value of other settings to determine their default value. When retrieving a setting value or default, the api allows the user to specify a filter, and the returned settings object will be filtered to only include the relevant setting. However, we are currently applying this filter to the settings object that we pass to the defaults providers. This means that the other setting(s) which determines the default value for the dependent setting might be hidden by the filter, and so an incorrect default will be returned. This PR fixes that logic so that the unfiltered set of all set settings is passed into the default values provider.
jordan-powers
added
:Core/Infra/Settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 9.2: