-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[DiskBBQ] save same vector operations when performing centroid filtering #138312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
| private final LongAccumulator accumulator; | ||
|
|
||
| IVFKnnSearchStrategy(float visitRatio, LongAccumulator accumulator) { | ||
| public IVFKnnSearchStrategy(float visitRatio, LongAccumulator accumulator) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need this on test to increase the visit ratio
benwtrent
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should improve things nicely! Do you have any benchmarks?
|
Benchmarks show a slight improvement: Before: After: |
It saves some vector operations by: