Generalize SnapshotShardContext and introduce its factory interface #138337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add a factory interface which allows customisation from plugins.
…t-context-base-class
…shard-snapshot-context-base-class
…shard-snapshot-context-base-class
…t-context-base-class
ywangd
added
:Distributed Coordination/Snapshot/Restore
elasticsearchmachine
added
the
Team:Distributed Coordination
Collaborator
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
ywangd
commented
Nov 20, 2025
Comment on lines
+291
to
+297
| protected int numberOfReplicasUpperBound() { | ||
| return cluster.numDataNodes() - 1; | ||
| } | ||
|
|
||
| public void run() throws InterruptedException { | ||
| run(true, true); | ||
| } |
Member
Author
There was a problem hiding this comment.
This entire class is almost extracted as is from SnapshotStressTestsIT except this two methods:
numberOfReplicasUpperBound()is overriden in stateless so that it returns a number based on the number of search nodes.- The two boolean flags are to control whether restart and shutdown are enabled in the test. I added them when debugging through issues to avoid too many variables. They are no longer used anywhere. But I intend to keep them since I may need them again in future when adding more stateless features.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extract a base class from SnapshotShardContext so that a different implementation can be provided by plugins. It also adds a
SnapshotShardContextFactoryinterface to encapsulates its creation process so that it is pluggable as well. The PR also split the cluster management code fromSnapshotStressTestsITand makes it reusable elsewhere.Relates: ES-13454