Cleanup esql request building api #138398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idegtiarenko
added
>non-issue
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
luigidellaquila
approved these changes
Nov 21, 2025
Contributor
luigidellaquila
left a comment
luigidellaquila
left a comment
There was a problem hiding this comment.
I like it!
We could probably consider to backport it, if it's not too much effort, to avoid conflicts in the future (the change is simple, but it impacts many files)
idegtiarenko
added
auto-backport
elasticsearchmachine
added
the
serverless-linked
ivancea
approved these changes
Nov 21, 2025
Contributor
ivancea
left a comment
ivancea
left a comment
There was a problem hiding this comment.
Thanks, looks good!
+1 to backporting, if not too troublesome
| * For secret access to ES|QL internals only. Do not use. | ||
| * TODO qualify export when ES|QL is modularized | ||
| */ | ||
| public class SharedSecrets { |
Contributor
Author
There was a problem hiding this comment.
This was only used in EsqlQueryRequestBuilder. I am not convinced we need it.
...ternalClusterTest/java/org/elasticsearch/xpack/esql/action/CrossClusterUsageTelemetryIT.java
Outdated
Show resolved
Hide resolved
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
idegtiarenko
added a commit
to idegtiarenko/elasticsearch
that referenced
this pull request
Nov 24, 2025
(cherry picked from commit daab115)
idegtiarenko
added a commit
to idegtiarenko/elasticsearch
that referenced
this pull request
Nov 24, 2025
(cherry picked from commit daab115)
Contributor
Author
|
Opened a 9.2 backport. |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 24, 2025
szybia
added a commit
to szybia/elasticsearch
that referenced
this pull request
Nov 24, 2025
…-json * upstream/main: (247 commits) Mute org.elasticsearch.xpack.inference.integration.SemanticTextIndexOptionsIT testValidateIndexOptionsWithBasicLicense elastic#138513 Mute org.elasticsearch.xpack.esql.heap_attack.HeapAttackLookupJoinIT testLookupExplosionBigString elastic#138510 This shouldn't be zero (elastic#138501) sum of empty histogram is now null (elastic#138378) Test ES|QL bfloat16 support (elastic#138499) Fix exception handling in S3 `compareAndExchangeRegister` (elastic#138488) Mute org.elasticsearch.xpack.exponentialhistogram.ExponentialHistogramFieldMapperTests testFormattedDocValues elastic#138504 Mute org.elasticsearch.ingest.geoip.IngestGeoIpClientYamlTestSuiteIT test {yaml=ingest_geoip/60_ip_location_databases/Test adding, getting, and removing ip location databases} elastic#138502 ESQL: Refactor HeapAttackIT (elastic#138432) [Inference API] Add ElasticInferenceServiceDenseTextEmbeddingsServiceSettings to InferenceNamedWriteablesProvider (elastic#138484) Store split indices (elastic#138396) ES|QL Update CHUNK to support chunking_settings as optional argument (elastic#138123) Extract common blob-update logic in `S3HttpHandler` (elastic#138490) Cleanup esql request building api (elastic#138398) Round sum and avg in exponential_histogram CSV tests (elastic#138472) ESQL: load exponential_histogram total count as double instead of long (elastic#138417) [SIMD] Use fixed width native types for better Java interoperability (elastic#138429) Do not use Min or Max as Top's surrogate when there is an outputField (elastic#138380) ES|QL: Fix generative tests (elastic#138478) Mute org.elasticsearch.xpack.inference.integration.AuthorizationTaskExecutorIT testCreatesEisChatCompletion_DoesNotRemoveEndpointWhenNoLongerAuthorized elastic#138480 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EsqlQueryRequestis structured as a mutable class with builder like setters.There are 2 factory methods to create an instance:
syncEsqlQueryRequestandasyncEsqlQueryRequest.This change makes those to accept a
queryparameter as this is the only mandatory field in the request as well as fixes several setters to be builder like.This is intended to make it obvious that
queryis mandatory and shorten overall query initialization chain.For example
syncEsqlQueryRequest().query("FROM *")becomessyncEsqlQueryRequest("FROM *")