Translate start/end to filter on @timestamp
#138412
Merged
+28
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixbarny
added
>non-issue
:StorageEngine/ES|QL
elasticsearchmachine
added
Team:StorageEngine
v9.3.0
external-contributor
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
5 tasks
kkrik-es
reviewed
Nov 21, 2025
| query = query.replace("$now", '"' + Instant.now().toString() + '"'); | ||
| var analyzed = tsAnalyzer.analyze(parser.createStatement(query)); | ||
| logger.trace(analyzed); | ||
| logger.trace("analyzed plan:\n{}", analyzed); |
Contributor
There was a problem hiding this comment.
Remove? Or set to debug? Same below.
Member
Author
There was a problem hiding this comment.
I think the trace level is fine to be able to debug/inspect the plan during testing. I've removed the redundant logger.trace(plan) in all of the other tests as we're doing that in here already.
kkrik-es
reviewed
Nov 21, 2025
| List<LogicalPlan> collect = plan.collect(Bucket.class::isInstance); | ||
| logger.trace(plan); | ||
| var filters = plan.collect(Filter.class::isInstance); | ||
| assertThat(filters, hasSize(1)); |
Member
Author
There was a problem hiding this comment.
There's one filter with multiple conditions (metric not null, timestamp >= start, timestamp <= end)
Member
Author
There was a problem hiding this comment.
I've adjusted the assertion in 6f88cf7 to check that there are two conditions for @timestamp.
kkrik-es
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a variant of #138027 where the target is main instead of the now merged esql/promql branch.
The start/end parameters are optional. If set, this creates a simple filter on the timestamp.
If start/end is not set, this doesn't create a filter and if @ start() and @ end() functions are used, it throws an error during parsing.
We don't attempt to infer start/end from other filters and we don't do anything special if there's another filter on @timestamp.
For instant queries where start=end=time, this essentially creates a filter that only includes data for a particular instant. We'll need to wire the lookback that will come after the initial window function support later on. Right now, instant queries will essentially always return an empty result. Maybe we just add a verifier rule to disallow instant queries.