Rename S3 CompareAndExchangeOperation
#138422
Merged
+37
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a preparatory step to providing an alternative implementation of the compare-and-exchange operation on S3, this commit renames the existing implementation and shifts the necessary exception-handling logic inside its `run` method for improved encapsulation.
DaveCTurner
added
>non-issue
:Distributed Coordination/Snapshot/Restore
elasticsearchmachine
added
v9.3.0
Team:Distributed Coordination
Collaborator
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
DaveCTurner
commented
Nov 21, 2025
| l | ||
| ) | ||
| ActionListener.run( | ||
| ActionListener.releaseBefore(clientReference, listener), |
Contributor
Author
There was a problem hiding this comment.
The only difference in behaviour is that this used to be releaseAfter, but I think that was only because we didn't have releaseBefore when the code was originally written.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a preparatory step to providing an alternative implementation of the
compare-and-exchange operation on S3, this commit renames the existing
implementation and shifts the necessary exception-handling logic inside
its
runmethod for improved encapsulation.