Add Validation to DER Parser for Sequence Length that Exceeds Max Signed Integer #138683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebarlas
added
>test
Collaborator
|
Pinging @elastic/es-security (Team:Security) |
ankit--sethi
approved these changes
Nov 26, 2025
ebarlas
added
v9.2.2
v8.19.8
v9.1.8
auto-backport
ebarlas
added a commit
to ebarlas/elasticsearch
that referenced
this pull request
Nov 26, 2025
Add validation to org.elasticsearch.common.ssl.DerParser for sequence length that exceeds maximum signed int.
ebarlas
added a commit
to ebarlas/elasticsearch
that referenced
this pull request
Nov 26, 2025
Add validation to org.elasticsearch.common.ssl.DerParser for sequence length that exceeds maximum signed int.
ebarlas
added a commit
to ebarlas/elasticsearch
that referenced
this pull request
Nov 26, 2025
Add validation to org.elasticsearch.common.ssl.DerParser for sequence length that exceeds maximum signed int.
Collaborator
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 26, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 26, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
org.elasticsearch.common.ssl.DerParserclass is missing a validation check on sequence length.If the length is in the "long form" and consists of 4 data bytes, they must fit in a Java signed 32-bit integer.
That check was missing and is added here.
Prior to the fix, the new test failed with
java.lang.NegativeArraySizeException.