Add the hostname to the node info #1433
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
ping. |
Member
|
It does not apply cleanly to master anymore, can you fix it? Also, use NetworkUtils#getLocalAddress instead of going through the lookup of it each time. |
Contributor
Author
|
patch rebased and simplified |
Member
|
I think that initializing the hostname outside of node info in the actual action was better, can you do that one? |
Contributor
Author
|
patch updated accordingly |
Member
|
Pushed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node names are cool, inet address are useful too, but hostnames often get more interesting, at least in my case.