-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Add back integ tests to distributions #14460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rpm and deb are still skipped, but this configures rest tests to run for zip and tgz distributions closes elastic#14361
|
I first tried this out from distribution/zip, maybe a missing dependency? I'm trying from the top-level build now. |
|
There are also quite a few things missing (just from looking at directory structure) that integ tests did before:
While these may seem "unimportant", I do think they are pretty common problems and these are easy tricks to prevent issues later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have an equivalent for the environment properties being set? These are fairly important, at least JAVA_HOME:
|
Works for me. I left some comments, all can be followups. |
|
And I fixed the dependency issue. Running the tests within |
|
+1 |
|
I also added the environment variables back in this PR. |
Add back integ tests to distributions
rpm and deb are still skipped, but this configures rest tests to run for
zip and tgz distributions
closes #14361