Skip to content

Conversation

@rjernst
Copy link
Member

@rjernst rjernst commented Nov 3, 2015

rpm and deb are still skipped, but this configures rest tests to run for
zip and tgz distributions

closes #14361

rpm and deb are still skipped, but this configures rest tests to run for
zip and tgz distributions

closes elastic#14361
@rjernst rjernst added :Delivery/Build Build or test infrastructure v5.0.0-alpha1 labels Nov 3, 2015
@rmuir
Copy link
Contributor

rmuir commented Nov 3, 2015

I first tried this out from distribution/zip, maybe a missing dependency?

:distribution:zip:integTest#clean UP-TO-DATE
:distribution:zip:integTest#extract

FAILURE: Build failed with an exception.

* What went wrong:
Cannot expand ZIP '/Users/rmuir/workspace/elasticsearch/distribution/zip/build/distributions/elasticsearch-3.0.0-SNAPSHOT.zip' as it does not exist.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

I'm trying from the top-level build now.

@rmuir
Copy link
Contributor

rmuir commented Nov 3, 2015

There are also quite a few things missing (just from looking at directory structure) that integ tests did before:

  1. using a random tmpdir not rooted under ES to ensure no bogus CWD dependencies: https://github.com/elastic/elasticsearch/blob/2.x/dev-tools/src/main/resources/ant/integration-tests.xml#L23-L26
  2. using a space in ES run directory to ensure no bogus URL/file handling:
    https://github.com/elastic/elasticsearch/blob/2.x/pom.xml#L121
  3. using a space for any plugin dependencies to check for the same in pluginmanager:
    https://github.com/elastic/elasticsearch/blob/2.x/pom.xml#L122

While these may seem "unimportant", I do think they are pretty common problems and these are easy tricks to prevent issues later.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have an equivalent for the environment properties being set? These are fairly important, at least JAVA_HOME:

https://github.com/elastic/elasticsearch/blob/2.x/dev-tools/src/main/resources/ant/integration-tests.xml#L162-L165

@rmuir
Copy link
Contributor

rmuir commented Nov 3, 2015

Works for me. I left some comments, all can be followups.

@rjernst
Copy link
Member Author

rjernst commented Nov 3, 2015

Thanks for the notes @rmuir! I created a follow up for the issues you mentioned: #14464

@rjernst
Copy link
Member Author

rjernst commented Nov 3, 2015

And I fixed the dependency issue. Running the tests within distribution/zip and distribution/tar now works.

@rmuir
Copy link
Contributor

rmuir commented Nov 3, 2015

+1

@rjernst
Copy link
Member Author

rjernst commented Nov 3, 2015

I also added the environment variables back in this PR.

rjernst added a commit that referenced this pull request Nov 3, 2015
Add back integ tests to distributions
@rjernst rjernst merged commit 64a01cf into elastic:master Nov 3, 2015
@rjernst rjernst deleted the distro_tests branch November 3, 2015 18:35
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team v5.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

elasticsearch integration tests are not run in gradle

3 participants