[DOCS] Document performRequestAsync #20217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pickypg
added
>docs
|
/cc @javanna I added the docs. |
docs/java-rest/usage.asciidoc
Outdated
There was a problem hiding this comment.
is it really not 2xx or is it 4xx or 5xx ?
There was a problem hiding this comment.
It's not 2xx as it currently exists:
return statusCode < 300 || (HttpHead.METHOD_NAME.equals(method) && statusCode == 404);That honestly makes sense because it also excludes any possibility of 3xx.
|
thanks a lot @pickypg LGTM besides the two comments I left |
|
LGTM thanks @pickypg |
This updates the docs to reflect that the asynchronous variants were renamed to have "Async" at the end.
pickypg
force-pushed
the
docs/desribe-renamed-async-methods
branch
from
9e53963 to
6ad92c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the docs to reflect that the asynchronous variants were renamed to have "Async" at the end.
It also adds some other minor details that I noticed along the way.