Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password Protected Keystore (Feature Branch) #49210

Closed
wants to merge 115 commits into from

Commits on Jul 11, 2019

  1. Reload secure settings with password (#43197)

    If a password is not set, we assume an empty string to be
    compatible with previous behavior.
    Only allow the reload to be broadcast to other nodes if TLS is
    enabled for the transport layer.
    jkakavas committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    98ad0eb View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2019

  1. Configuration menu
    Copy the full SHA
    5b0b591 View commit details
    Browse the repository at this point in the history
  2. Add passphrase support to elasticsearch-keystore (#38498)

    This change adds support for keystore passphrases to all subcommands
    of the elasticsearch-keystore cli tool and adds a subcommand for
    changing the passphrase of an existing keystore.
    The work to read the passphrase in Elasticsearch when
    loading, which will be addressed in a different PR.
    
    Subcommands of elasticsearch-keystore can handle (open and create)
    passphrase protected keystores
    
    When reading a keystore, a user is only prompted for a passphrase
    only if the keystore is passphrase protected.
    
    When creating a keystore, a user is allowed (default behavior) to create one with an
    empty passphrase
    
    Passphrase can be set to be empty when changing/setting it for an
    existing keystore
    
    Relates to: #32691
    Supersedes: #37472
    jkakavas committed Jul 23, 2019
    Configuration menu
    Copy the full SHA
    9398aac View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2019

  1. Configuration menu
    Copy the full SHA
    c7882c3 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2019

  1. Restore behavior for force parameter (#44847)

    Turns out that the behavior of `-f` for the add and add-file sub
    commands where it would also forcibly create the keystore if it
    didn't exist, was by design - although undocumented.
    This change restores that behavior auto-creating a keystore that
    is not password protected if the force flag is used. The force
    OptionSpec is moved to the BaseKeyStoreCommand as we will presumably
    want to maintain the same behavior in any other command that takes
    a force option.
    jkakavas committed Jul 26, 2019
    Configuration menu
    Copy the full SHA
    6684375 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2019

  1. [ML-DataFrame] Muting tests for backport (#44850)

    Mutes data frame BWC tests prior to backporting #44768
    droberts195 authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    c38fa7a View commit details
    Browse the repository at this point in the history
  2. Treat PostDataActionResponse.DataCounts.bucketCount as incremental ra…

    …ther than absolute (total). (#44803)
    przemekwitek authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    83db007 View commit details
    Browse the repository at this point in the history
  3. [ML-DataFrame] Adjust data frame stats BWC following backport (#44852)

    This change adjusts the changes of #44768 to account
    for the backport to the 7.x branch in #44848.
    droberts195 authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    2069e38 View commit details
    Browse the repository at this point in the history
  4. do not assert on indexer state (#44854)

    remove the unreliable check for the state change
    
    fixes #44813
    Hendrik Muhs authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    e4c35eb View commit details
    Browse the repository at this point in the history
  5. [DOCS] Adds allow no datafeeds query param to the GET, GET stats and …

    …STOP datafeed APIs (#44499)
    szabosteve authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    24e009b View commit details
    Browse the repository at this point in the history
  6. [GEO] Fix GeoShapeQueryBuilder to check for valid spatial relations

    Refactor left out the spatial strategy check in GeoShapeQueryBuilder.relation
    setter method. This commit adds that check back in.
    nknize authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    9c4ea84 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    cade368 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    ba34dce View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    4c65468 View commit details
    Browse the repository at this point in the history
  10. Fix an NPE when requesting inner hits and _source is disabled. (#44836)

    This PR makes two changes to FetchSourceSubPhase when _source is disabled and
    we're in a nested context:
    * If no source filters are provided, return early to avoid an NPE.
    * If there are source filters, make sure to throw an exception.
    
    The behavior was chosen to match what currently happens in a non-nested context.
    jtibshirani authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    d420bc4 View commit details
    Browse the repository at this point in the history
  11. Add Clone Index API (#44267)

    Adds an API to clone an index. This is similar to the index split and shrink APIs, just with the
    difference that the number of primary shards is kept the same. In case where the filesystem
    provides hard-linking capabilities, this is a very cheap operation.
    
    Indexing cloning can be done by running `POST my_source_index/_clone/my_target_index` and it
    supports the same options as the split and shrink APIs.
    
    Closes #44128
    ywelsch authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    91c35aa View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    31a8ce9 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    8bbf546 View commit details
    Browse the repository at this point in the history
  14. Add missing ZonedDateTime methods for joda compat layer (#44829)

    While joda no longer exists in the apis for 7.x, the compatibility layer
    still exists with helper methods mimicking the behavior of joda for
    ZonedDateTime objects returned for date fields in scripts. This layer
    was originally intended to be removed in 7.0, but is now likely to exist
    for the lifetime of 7.x.
    
    This commit adds missing methods from ChronoZonedDateTime to the compat
    class. These methods were not part of joda, but are needed to act like a
    real ZonedDateTime.
    
    relates #44411
    rjernst authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    a05805a View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    78ca898 View commit details
    Browse the repository at this point in the history
  16. Asynchronously connect to remote clusters (#44825)

    Refactors RemoteClusterConnection so that it no longer blockingly connects to remote clusters.
    
    Relates to #40150
    ywelsch authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    c9a9d9e View commit details
    Browse the repository at this point in the history
  17. Adapt BWC condition for clone index API after backport (#44267)

    Changes the BWC conditions for the clone index API after backport of the feature to 7.x
    ywelsch authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    d340467 View commit details
    Browse the repository at this point in the history
  18. Add option to filter ILM explain response (#44777)

    In order to make it easier to interpret the output of the ILM Explain
    API, this commit adds two request parameters to that API:
    
    - `only_managed`, which causes the response to only contain indices
      which have `index.lifecycle.name` set
    - `only_errors`, which causes the response to contain only indices in an
      ILM error state
    
    "Error state" is defined as either being in the `ERROR` step or having
    `index.lifecycle.name` set to a policy that does not exist.
    gwbrown authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    8510717 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    56e35b8 View commit details
    Browse the repository at this point in the history
  20. Upgrade to Lucene 8.2.0 release (#44859)

    iverase authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    f4edb31 View commit details
    Browse the repository at this point in the history
  21. Document xpack.security.authc.saml.realm for Kibana (#44705)

    Since 7.3, it's possible to explicitly configure the SAML realm to
    be used in Kibana's configuration. This in turn, eliminates the need
    of properly setting `xpack.security.public.*` settings in Kibana
    and largely simplifies relevant documentation.
    This also changes `xpack.security.authProviders` to
    `xpack.security.authc.providers` as the former was deprecated in
    favor of the latter in 7.3 in Kibana
    jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    944c998 View commit details
    Browse the repository at this point in the history
  22. Force Merge should reject requests with only_expunge_deletes and `m…

    …ax_num_segments` set (#44761)
    
    This commit changes the ForceMergeRequest.validate() method so that it does 
    not accept the parameters only_expunge_deletes and max_num_segments 
    to be set at the same time.
    
    The motivation is that InternalEngine.forceMerge() just ignores the max. number 
    of segments parameter when the only expunge parameter is set to true, leaving 
    the wrong impression to the user that max. number of segments has been applied. 
    It also changes InternalEngine.forceMerge() so that it now throws an exception 
    when both parameters are set, and modifies tests where needed.
    
    Because it changes the behavior of the REST API I marked this as >breaking. 
    
    Closes #43102
    tlrx authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    df9b97a View commit details
    Browse the repository at this point in the history
  23. Deprecate setting processors to more than available (#44889)

    Today the processors setting is permitted to be set to more than the
    number of processors available to the JVM. The processors setting
    directly sizes the number of threads in the various thread pools, with
    most of these sizes being a linear function in the number of
    processors. It doesn't make any sense to set processors very high as the
    overhead from context switching amongst all the threads will overwhelm,
    and changing the setting does not control how many physical CPU
    resources there are on which to schedule the additional threads. We have
    to draw a line somewhere and this commit deprecates setting processors
    to more than the number of available processors. This is the right place
    to draw the line given the linear growth as a function of processors in
    most of the thread pools, and that some are capped at the number of
    available processors already.
    jasontedor authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    fc1158b View commit details
    Browse the repository at this point in the history
  24. Ensure cluster is stable in ShrinkIndexIT.testShrinkThenSplitWithFail…

    …edNode (#44860)
    
    The test ShrinkIndexIT.testShrinkThenSplitWithFailedNode sometimes fails 
    because the resize operation is not acknowledged (see #44736). This resize 
    operation creates a new index "splitagain" and it results in a cluster state 
    update (TransportResizeAction uses MetaDataCreateIndexService.createIndex() 
    to create the resized index). This cluster state update is expected to be 
    acknowledged by all nodes (see IndexCreationTask.onAllNodesAcked()) but 
    this is not always true: the data node that was just stopped in the test before 
    executing the resize operation might still be considered as a "faulty" node
     (and not yet removed from the cluster nodes) by the FollowersChecker. The 
    cluster state is then acked on all nodes but one, and it results in a non 
    acknowledged resize operation.
    
    This commit adds an ensureStableCluster() check after stopping the node in 
    the test. The goal is to ensure that the data node has been correctly removed 
    from the cluster and that all nodes are fully connected to each before moving 
    forward with the resize operation.
    
    Closes #44736
    tlrx authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    f8133ec View commit details
    Browse the repository at this point in the history
  25. [DOCS] Amends data frame analytics resources, GET, and PUT API docs (#…

    …44806)
    
    This PR addresses the feedback in  elastic/ml-team#175 (comment).
    
    * Adds an example to `analyzed_fields`
    * Includes `source` and `dest` objects inline in the resource page
    * Lists `model_memory_limit` in the PUT API page
    * Amends the `analysis` section in the resource page
    * Removes Properties headings in subsections
    szabosteve authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    62f8f85 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    0a15aa1 View commit details
    Browse the repository at this point in the history
  27. Fix Test Failure in ScalingThreadPoolTests (#44898)

    * Due to #44894 some constellations log a deprecation warning here now
    * Fixed by checking for that
    original-brownbear authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    c13dda1 View commit details
    Browse the repository at this point in the history
  28. Ensure index is green in SimpleClusterStateIT.testIndicesOptions() (#…

    …44893)
    
    SimpleClusterStateIT testIndicesOptions failed in #44817 because it tries to close 
    an index at the beginning of the test. With random index settings, it is possible that 
    the index has a high number of shards (10) and replicas (1), which means that on 
    CI this index can take time to be fully allocated.
    
    The close index request can fail in the case where replicas are still recovering operations. 
    Thiscommit adds a simple ensureGreen() at the beginning of the test to be sure that all 
    replicas are started before trying to close the index.
    
    closes #44817
    tlrx authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    e37df82 View commit details
    Browse the repository at this point in the history
  29. Limit processors by available processors (#44894)

    This commit limits the processors setting to be more than the number of
    available processors.
    jasontedor authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    fb3d70a View commit details
    Browse the repository at this point in the history
  30. Fix failing scaling thread pool test

    The previous commit took away the distinction between relying on the
    defaults versus relying on an explicit setting for processors. This
    commit adds this back, and adjusts the logic to account for the fact
    that processors can not exceed available processors any longer.
    jasontedor authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    5df6cc8 View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    08c02e7 View commit details
    Browse the repository at this point in the history
  32. Geo: refactor geo mapper and query builder (#44884)

    Refactors out the indexing and query generation logic out of the
    mapper and query builder into a separate unit-testable classes.
    imotov authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    6908663 View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    7411325 View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    aa0c83d View commit details
    Browse the repository at this point in the history
  35. Optimize Min and Max BKD optimizations (#44315)

    MinAggregator - skip BKD optimization when no result found after 1024 lookups.
    MaxAggregator - skip unnecessary conversions.
    michalperlak authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    b9a17b4 View commit details
    Browse the repository at this point in the history
  36. Guard open connection call in RemoteClusterConnection (#44921)

    Fixes an issue where a call to openConnection was not properly guarded, allowing an exception
    to bubble up to the uncaught exception handler, causing test failures.
    
    Closes #44912
    ywelsch authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    37b39a6 View commit details
    Browse the repository at this point in the history
  37. RestController should not consume request content (#44902)

    The change #37504 modifies the BaseRestHandler to make it reject all requests 
    that have an unconsumed body. The notion of consumed or unconsumed body
     is carried by the RestRequest object and its contentConsumed attribute, which
     is set to true when the content() or content(true) methods are used.
    
    In our REST layer, we usually expect the RestHandlers to consume the request 
    content when needed, but it appears that the RestController always consumes
     the content upfront.
    
    This commit changes the content() method used by the RestController so that it 
    does not mark the content as consumed.
    tlrx authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    929ef7f View commit details
    Browse the repository at this point in the history
  38. Remove client feature tracking (#44929)

    This commit removes the infrastructure for client feature tracking. We
    introduced this functionality to support clients that do not necessarily
    understand all the features that the server might support, for example,
    customs in the cluster state provided by plugins that a client might not
    have. This can arise in situations such as rolling upgrades from the OSS
    distribution to the default distribution. With the removal of the
    transport client, this infrastructure is no longer needed. This commit
    removes client feature tracking from the server in 8.0.0.
    jasontedor authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    d2d7f26 View commit details
    Browse the repository at this point in the history
  39. Expand logging when SAML Audience condition fails (#44334)

    A mismatched configuration between the IdP and SP will often result in
    SAML authentication attempts failing because the audience condition is
    not met (because the IdP and SP disagree about the correct form of the
    SP's Entity ID).
    
    Previously the error message in this case did not provide sufficient
    information to resolve the issue because the IdP's expected audience
    would be truncated if it exceeeded 32 characters. Since the error did
    not provide both IDs in full, it was not possible to determine the
    correct fix (in detail) based on the error alone.
    
    This change expands the message that is included in the thrown
    exception, and also adds additional logging of every failed audience
    condition, with diagnostics of the match failure.
    
    Resolves: #44305
    tvernum authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    3c74664 View commit details
    Browse the repository at this point in the history
  40. Cleanup Deadcode o.e.indices (#44931)

    * none of this is used anywhere
    original-brownbear authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    b9b242e View commit details
    Browse the repository at this point in the history
  41. Configuration menu
    Copy the full SHA
    f5b7feb View commit details
    Browse the repository at this point in the history
  42. Don't use TypeField for nested filters (#44482)

    We changed things in #27469 to filter parent docs by using an exists query on the 
    primary_term field. However, the equivalent query for nested documents is still using 
    the type field. This commit makes newNestedFilter build the complement of 
    newNonNestedFilter instead.
    romseygeek authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    270e256 View commit details
    Browse the repository at this point in the history
  43. Do not block transport thread on startup (#44939)

    We currently block the transport thread on startup, which has caused test failures. I think this is
    some kind of deadlock situation. I don't think we should even block a transport thread, and
    there's also no need to do so. We can just reject requests as long we're not fully set up. Note
    that the HTTP layer is only started much later (after we've completed full start up of the
    transport layer), so that one should be completely unaffected by this.
    
    Closes #41745
    ywelsch authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    6f8e1a3 View commit details
    Browse the repository at this point in the history
  44. Configuration menu
    Copy the full SHA
    f96e253 View commit details
    Browse the repository at this point in the history
  45. [Docs] Update daterange-aggregation.asciidoc (#44730)

    Correcting the value to be the same as that specified for "missing".
    sandeepkanabar authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    bc8e75c View commit details
    Browse the repository at this point in the history
  46. [DOCS] Amends REST API TOC. (#44948)

    szabosteve authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    f241e30 View commit details
    Browse the repository at this point in the history
  47. Support fixture in repository-gcs:thirdPartyTest and fix GCS fixture (#…

    …44885)
    
    It turns out that today :plugins:repository-gcs:thirdPartyTest can only
    run against real GCS.
    Moreover, thirdPartyTest is not a part of check, so these tests are not
    running on intake build.
    This commit addresses the issue and makes repository-gcs:thirdPartyTest
    work with both fixture and real GCS.
    To do that, except adjusting build and test itself, I had to make
    changes to the fixture, because previously it was ignoring
    BlobListOption.currentDirectory() in the list call.
    Andrey Ershov authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    3eb5d26 View commit details
    Browse the repository at this point in the history
  48. Configuration menu
    Copy the full SHA
    7b9675b View commit details
    Browse the repository at this point in the history
  49. [DOCS] Rewrite prefix query docs (#41955)

    jrodewig authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    5b6e049 View commit details
    Browse the repository at this point in the history
  50. [ML] Outlier detection should only fetch docs that have the analyzed … (

    #44944)
    
    As data frame rows with missing values for analyzed fields are skipped,
    we can be more efficient by including a query that only picks documents
    that have values for all analyzed fields. Besides improving the number
    of documents we go through, we also provide a more accurate measurement
    of how many rows we need which reduces the memory requirements.
    
    This also adds an integration test that runs outlier detection on data
    with missing fields.
    dimitris-athanasiou authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    3b49a0d View commit details
    Browse the repository at this point in the history
  51. [DOCS] Reformat script query (#44882)

    jrodewig authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    da70449 View commit details
    Browse the repository at this point in the history
  52. TaskListener#onFailure to accept Exception instead of Throwable (#44946)

    TaskListener accepts today Throwable in its onFailure method. Though
    looking at where it is called (TransportAction), it can never be
    notified of a Throwable.
    
    This commit changes the signature of TaskListener#onFailure so that it
    accepts an `Exception` rather than a `Throwable` as second argument.
    javanna authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    c7e4cbf View commit details
    Browse the repository at this point in the history
  53. Fix testBlockingIncomingRequests (#44939)

    Adapted test to take non-blocking nature into account.
    ywelsch authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    e5c3e61 View commit details
    Browse the repository at this point in the history
  54. [ML] Catch any error thrown while closing data frame analytics process (

    #44958)
    
    In case closing the process throws an exception we should be catching
    it no matter its type. The process may have terminated because of a
    fatal error in which case closing the process will throw a server
    error, not an `IOException`. If this happens we fail to mark the
    persistent task as failed and the task gets in limbo.
    dimitris-athanasiou authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    4e7a1a7 View commit details
    Browse the repository at this point in the history
  55. [GEO] Refactor DeprecatedParameters in AbstractGeometryFieldMapper (#…

    …44923)
    
    Refactors DeprecatedParameters specific to legacy geo_shape out of
    AbstractGeometryFieldMapper.TypeParser#parse.
    nknize authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    8652ef4 View commit details
    Browse the repository at this point in the history
  56. Geo: fix geo query decomposition (#44924)

    The recent refactoring introduced an issue where queries where not
    going through the decomposition processing.
    
    Fixes #44891
    imotov authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    099d7be View commit details
    Browse the repository at this point in the history
  57. Fix Snapshot CLI Build Portability (#44919)

    The snapshot CLI tool does not use the `java` in `JAVA_HOME` but instead uses it from the `PATH` which will lead to some portability issues with the wrong `java` being used as the ES build itself does allow for having a different `java` than what is in `JAVA_HOME` on the `PATH`
    original-brownbear authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    025b92e View commit details
    Browse the repository at this point in the history
  58. Rename indexlifecycle to ilm and snapshotlifecycle to slm (#44917)

    As a followup to #44725 and #44608, which renamed the packages within
    the x-pack project, this renames the packages within the core x-pack
    project. It also renames 'snapshotlifecycle' within the HLRC to slm.
    dakrone authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    3f80ff8 View commit details
    Browse the repository at this point in the history
  59. Adjust skip version after backport (#44603)

    Relates #44603
    dnhatn authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    decb1da View commit details
    Browse the repository at this point in the history
  60. Remove leniency in reset engine from translog (#44711)

    Replaying operations from the local translog must never fail as those
    operations were processed successfully on the primary before and the
    mapping is up to update already. This change removes leniency during
    resetting engine from translog in IndexShard and InternalEngine.
    dnhatn authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    1c86c21 View commit details
    Browse the repository at this point in the history
  61. Fix JodaCompatibleZonedDateTime casts in Painless (#44874)

    This is a temporary fix during the Joda to Java datetime transition. This will 
    implicitly cast a JodaCompatibleZonedDateTime to a ZonedDateTime for 
    both def and static types. This is necessary to insulate users from needing 
    to know about JodaCompatibleZonedDateTime explicitly.
    jdconrad authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    c34c064 View commit details
    Browse the repository at this point in the history
  62. Release Pooled Buffers Earlier for HTTP Requests (#44952)

    * We should release the buffers right after copying and not only do so after we did all the request handling on the copy
    * Relates #44564
    original-brownbear authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    405c51e View commit details
    Browse the repository at this point in the history
  63. Explicitly fail if a realm only exists in keystore (#44471)

    There are no realms that can be configured exclusively with secure
    settings. Every realm that supports secure settings also requires one
    or more non-secure settings.
    However, sometimes a node will be configured with entries in the
    keystore for which there is nothing in elasticsearch.yml - this may be
    because the realm we removed from the yml, but not deleted from the
    keystore, or it could be because there was a typo in the realm name
    which has accidentially orphaned the keystore entry.
    
    In these cases the realm building would fail, but the error would not
    always be clear or point to the root cause (orphaned keystore
    entries). RealmSettings would act as though the realm existed, but
    then fail because an incorrect combination of settings was provided.
    
    This change causes realm building to fail early, with an explicit
    message about incorrect keystore entries.
    tvernum authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    03a204b View commit details
    Browse the repository at this point in the history
  64. Fix aggregators early termination with breadth-first mode (#44963)

    This commit fixes a bug when a deferred aggregator tries to early terminate the collection. In such case the CollectionTerminatedException is not caught and
    the search fails on the shard. This change makes sure that we catch the exception in order to continue the deferred collection on the next leaf.
    
    Fixes #44909
    jimczi authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    ba57635 View commit details
    Browse the repository at this point in the history
  65. Mute SnapshotLifecycleServiceTests#testPolicyCRUD

    Relates to #44997
    davidkyle authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    b8e668a View commit details
    Browse the repository at this point in the history
  66. Close nodes properly in Coordinator tests (#44967)

    Today closing a `ClusterNode` in an `AbstractCoordinatorTestCase` uses
    `onNode()` so has no effect if the node is not in the current list of nodes.
    It also discards the `Runnable` it creates without having run it, so has no
    effect anyway.
    
    This commit makes these tests much stricter about properly closing the nodes
    started during `Coordinator` tests, by tracking the persisted states that are
    opened, and adds an assertion to catch the trappy requirement that the closing
    node still belongs to the cluster.
    DaveCTurner authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    24cb30a View commit details
    Browse the repository at this point in the history
  67. Optimize Netty Frame Decoding (#44664)

    * We should not create a new wrapper object if there's no bytes in the `ByteBuf`
    * We should not create a new wrapped `ByteBuf` if it can't contain a message anyway because it doesn't even have enough bytes for a header left
    original-brownbear authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    ddd179b View commit details
    Browse the repository at this point in the history
  68. Configuration menu
    Copy the full SHA
    88711e1 View commit details
    Browse the repository at this point in the history
  69. S3 3rd Party Test Goal (#44799)

    * Create S3 Third Party Test Task that Covers the S3 CLI Tool
    * Adjust snapshot cli test tool tests to work with real S3
      * Build adjustment
      * Clean up repo path before testing
    * Dedup the logic for asserting path contents by using the correct utility method here that somehow became unused
    original-brownbear authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    91472ea View commit details
    Browse the repository at this point in the history
  70. Remove leniency during replay translog in peer recovery (#44989)

    This change removes leniency in InternalEngine during replaying translog
    in peer recovery.
    dnhatn authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    49a4f7d View commit details
    Browse the repository at this point in the history
  71. Configuration menu
    Copy the full SHA
    ee67c94 View commit details
    Browse the repository at this point in the history
  72. Mute WatcherRestIT 20_minimal_body

    Relates to #43988
    davidkyle authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    08608d2 View commit details
    Browse the repository at this point in the history
  73. [ML][Data Frames] unify validation exceptions between PUT/_preview (#…

    …44983)
    
    * [ML][Data Frames] unify validation exceptions between PUT/_preview
    
    * addressing PR comments
    benwtrent authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    393bf48 View commit details
    Browse the repository at this point in the history
  74. Geo: move indexShape to AbstractGeometryFieldMapper.Indexer (#44979)

    Move indexShape functionality into AbstractGeometryFieldMapper to make
    it more unit testable.
    
    Relates to #43644
    imotov authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    7648868 View commit details
    Browse the repository at this point in the history
  75. Move nio channel initialization to event loop (#43780)

    Currently in the transport-nio work we connect and bind channels on the
    a thread before the channel is registered with a selector. Additionally,
    it is at this point that we set all the socket options. This commit
    moves these operations onto the event-loop after the channel has been
    registered with a selector. It attempts to set the socket options for a
    non-server channel at registration time. If that fails, it will attempt
    to set the options after the channel is connected. This should fix
    #41071.
    Tim-Brooks authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    15c0f23 View commit details
    Browse the repository at this point in the history
  76. introduce 7.2.2 as a version (#44375)

    jakelandis authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    501f41f View commit details
    Browse the repository at this point in the history
  77. Configuration menu
    Copy the full SHA
    8c23c92 View commit details
    Browse the repository at this point in the history
  78. Configuration menu
    Copy the full SHA
    326c247 View commit details
    Browse the repository at this point in the history
  79. [DOCS] Modified section headings, edited text for clarity. (#44988)

    * [DOCS] Modified section headings, edited text for clarity.
    
    * [DOCS] Modified section headings, edited text for clarity.
    
    * [DOCS] Modified section headings, edited text for clarity.
    MK Swanson authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    8921cf0 View commit details
    Browse the repository at this point in the history
  80. Adds usage stats for vectors: (#44512)

    An example of a reply:
    
    _xpack/usage
    "vectors": {
        "available": true,
        "enabled": true,
        "dense_vector_fields_count" : 1,
        "sparse_vector_fields_count" : 1,
        "dense_vector_dims_avg_count" : 100
    }
    mayya-sharipova authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    731ddbd View commit details
    Browse the repository at this point in the history
  81. Rename HLRC 'indexlifecycle' components to 'ilm' (#44982)

    Related to #44917 and #44725, this commit renames the HLRC components
    for indexlifecycle to ilm.
    dakrone authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    6acea3c View commit details
    Browse the repository at this point in the history
  82. Small optimizations in VectorsUsageTransportAction

    Relates to PR#44512
    mayya-sharipova authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    cd5bf44 View commit details
    Browse the repository at this point in the history
  83. Configuration menu
    Copy the full SHA
    47f9c35 View commit details
    Browse the repository at this point in the history
  84. [SPATIAL] New ShapeFieldMapper for indexing cartesian geometries (#44980

    )
    
    This commit adds a new ShapeFieldMapper to the xpack spatial module for
    indexing arbitrary cartesian geometries using a new field type called shape.
    The indexing approach leverages lucene's new XYShape field type which is
    backed by BKD in the same manner as LatLonShape but without the WGS84
    latitude longitude restrictions. The new field mapper builds on and
    extends the refactoring effort in AbstractGeometryFieldMapper and accepts
    shapes in either GeoJSON or WKT format (both of which support non geospatial geometries).
    
    Tests are provided in the ShapeFieldMapperTest class in the same manner
    as GeoShapeFieldMapperTests and LegacyGeoShapeFieldMapperTests.
    Documentation for how to use the new field type and what parameters are
    accepted is included. The QueryBuilder for searching indexed shapes is provided in a separate commit.
    nknize authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    5efc017 View commit details
    Browse the repository at this point in the history
  85. Improve errors when TLS files cannot be read (#44787)

    This change improves the exception messages that are thrown when the
    system cannot read TLS resources such as keystores, truststores,
    certificates, keys or certificate-chains (CAs).
    
    This change specifically handles:
    
    - Files that do not exist
    - Files that cannot be read due to file-system permissions
    - Files that cannot be read due to the ES security-manager
    
    Relates: #43079
    tvernum authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    7a0a4a5 View commit details
    Browse the repository at this point in the history
  86. [Docs] Fix typo in rank-eval.asciidoc (#44978)

    Jesse Wright authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    2ad531a View commit details
    Browse the repository at this point in the history
  87. Clarify which circuit breaker settings are static (#44992)

    Most of the circuit breaker settings are dynamically configurable.
    However, `indices.breaker.total.use_real_memory` is not. With this
    commit we add a clarifying note that this specific setting is static.
    
    Closes #44974
    danielmitterdorfer authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    6a30267 View commit details
    Browse the repository at this point in the history
  88. Mute all GC Disruption Simulating Tests (#45032)

    * We suspect these might be causing #43387 so let's mute them on `master` temporarily to find out
    original-brownbear authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    73bbb7f View commit details
    Browse the repository at this point in the history
  89. Stop Recreating Wrapped Handlers in RestController (#44964)

    * We shouldn't be recreating wrapped REST handlers over and over for every request. We only use this hook in x-pack and the wrapper there does not have any per request state.
      This is inefficient and could lead to some very unexpected memory behavior
       => I made the logic create the wrapper on handler registration and adjusted the x-pack wrapper implementation to correctly forward the circuit breaker and content stream flags
    original-brownbear authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    0c089d6 View commit details
    Browse the repository at this point in the history
  90. Reenable Parallel Restore Test on Windows (#45037)

    * As a result of #44096 this test shouldn't fail anymore on `master` and `7.4`+ so we should reenable it there
      * For older versions we won't backport that change so the tests should stay disabled there
    * Closes #44671
    original-brownbear authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    cc53cc4 View commit details
    Browse the repository at this point in the history
  91. Cleanup Various Action- Listener and Runnable Usages (#42273)

    * Dry up code for creating simple `ActionRunnable` a little
    * Shorten some other code around `ActionListener` usage, in particular
    when wrapping it in a `TransportResponseListener`
    original-brownbear authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    fecde5d View commit details
    Browse the repository at this point in the history
  92. Configuration menu
    Copy the full SHA
    dadac0c View commit details
    Browse the repository at this point in the history
  93. Indicate that some user APIs handle built-in users (#44857)

    The Get Users API also returns users form the restricted realm or built-in users,
     as we call them in our docs. One can also change the passwords of built-in 
    users with the Change Password API
    jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    7fcdb41 View commit details
    Browse the repository at this point in the history
  94. Introduce 7.3.1 version (#45049)

    polyfractal authored and jkakavas committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    fb9f592 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2019

  1. Adjust docs for password protected keystore (#45054)

    This commit adds relevant parts in the elasticsearch-keystore
    sub-commands reference docs and in the reload secure settings API
    doc.
    jkakavas committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    0f34e9f View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2019

  1. Configuration menu
    Copy the full SHA
    4ad6b51 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2019

  1. Configuration menu
    Copy the full SHA
    4780880 View commit details
    Browse the repository at this point in the history
  2. Handle pwd protected keystores in all CLI tools (#45289)

    This change ensures that `elasticsearch-setup-passwords` and
    `elasticsearch-saml-metadata` can handle a password protected
    elasticsearch.keystore.
    For setup passwords the user would be prompted to add the
    elasticsearch keystore password upon running the tool. There is no
    option to pass the password as a parameter as we assume the user is
    present in order to enter the desired passwords for the built-in
    users.
    For saml-metadata, we prompt for the keystore password at all times
    even though we'd only need to read something from the keystore when
    there is a signing or encryption configuration.
    jkakavas committed Aug 16, 2019
    Configuration menu
    Copy the full SHA
    d1cb96a View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2019

  1. Configuration menu
    Copy the full SHA
    e0b949e View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2019

  1. Modify docs for setup passwords and saml metadata cli (#45797)

    Adds a sentence in the documentation of `elasticsearch-setup-passwords`
    and `elasticsearch-saml-metadata` to describe that users would be
    prompted for the keystore's password when running these CLI tools,
    when the keystore is password protected.
    
    Co-Authored-By: Lisa Cawley <lcawley@elastic.co>
    jkakavas and lcawl committed Aug 28, 2019
    Configuration menu
    Copy the full SHA
    5d461da View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2019

  1. Configuration menu
    Copy the full SHA
    5be2efb View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2019

  1. Configuration menu
    Copy the full SHA
    b674115 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2019

  1. Configuration menu
    Copy the full SHA
    ae32d3c View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2019

  1. Configuration menu
    Copy the full SHA
    e928c27 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2019

  1. Configuration menu
    Copy the full SHA
    a4a2093 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2019

  1. Configuration menu
    Copy the full SHA
    e0181b4 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2019

  1. Configuration menu
    Copy the full SHA
    0944b31 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2019

  1. Elasticsearch keystore passphrase for startup scripts (#44775)

    This commit allows a user to provide a keystore password on Elasticsearch
    startup, but only prompts when the keystore exists and is encrypted.
    
    The entrypoint in Java code is standard input. When the Bootstrap class is
    checking for secure keystore settings, it checks whether or not the keystore
    is encrypted. If so, we read one line from standard input and use this as the
    password. For simplicity's sake, we allow a maximum passphrase length of 128
    characters. (This is an arbitrary limit and could be increased or eliminated.
    It is also enforced in the keystore tools, so that a user can't create a
    password that's too long to enter at startup.)
    
    In order to provide a password on standard input, we have to account for four
    different ways of starting Elasticsearch: the bash startup script, the Windows
    batch startup script, systemd startup, and docker startup. We use wrapper
    scripts to reduce systemd and docker to the bash case: in both cases, a
    wrapper script can read a passphrase from the filesystem and pass it to the
    bash script.
    
    In order to simplify testing the need for a passphrase, I have added a
    has-passwd command to the keystore tool. This command can run silently, and
    exit with status 0 when the keystore has a password. It exits with status 1 if
    the keystore doesn't exist or exists and is unencrypted.
    
    A good deal of the code-change in this commit has to do with refactoring
    packaging tests to cleanly use the same tests for both the "archive" and the
    "package" cases. This required not only moving tests around, but also adding
    some convenience methods for an abstraction layer over distribution-specific
    commands.
    
    I will write some user-facing documentation for these changes in a follow-up
    commit.
    williamrandolph committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    0a0db4b View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2019

  1. Configuration menu
    Copy the full SHA
    3229641 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2a34fe0 View commit details
    Browse the repository at this point in the history