Ensure latch is counted down when assertion trips #60800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ReloadSecureSettingsIT uses latches to ensure coordination across requests to the underlying in memory cluster. However, in the case of an expected failure, if the assertion fails, the latch will never be counted down, and will cause the test to hang indefinitely. This commit ensures the latch is always counted down with a try/finally. relates elastic#51546
rjernst
added
>test
|
Pinging @elastic/es-core-infra (:Core/Infra/Settings) |
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Aug 6, 2020
The ReloadSecureSettingsIT makes requests to the reload settings apis. In 7.x, the client used from the integ test infrastructure may be a transport client. In that case, the expected exception type, and causes the test to fail (though it will hang indefinitely due to not counting down the latch, see elastic#60800). This commit adds unwrapping of the remote exception to get the underlying expected exception. closes elastic#51546
pugnascotia
approved these changes
Aug 6, 2020
rjernst
added a commit
that referenced
this pull request
Aug 6, 2020
The ReloadSecureSettingsIT uses latches to ensure coordination across requests to the underlying in memory cluster. However, in the case of an expected failure, if the assertion fails, the latch will never be counted down, and will cause the test to hang indefinitely. This commit ensures the latch is always counted down with a try/finally. relates #51546
rjernst
added a commit
that referenced
this pull request
Aug 13, 2020
The ReloadSecureSettingsIT makes requests to the reload settings apis. In 7.x, the client used from the integ test infrastructure may be a transport client. In that case, the expected exception type, and causes the test to fail (though it will hang indefinitely due to not counting down the latch, see #60800). This commit adds unwrapping of the remote exception to get the underlying expected exception. closes #51546
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ReloadSecureSettingsIT uses latches to ensure coordination across
requests to the underlying in memory cluster. However, in the case of an
expected failure, if the assertion fails, the latch will never be
counted down, and will cause the test to hang indefinitely. This commit
ensures the latch is always counted down with a try/finally.
relates #51546