Skip to content

Add an option to write the aggregation type in the response #7278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add an option to write the aggregation type in the response #7278

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/main/java/org/elasticsearch/search/aggregations/InternalAggregation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,12 @@ protected static void writeSize(int size, StreamOutput out) throws IOException {
@Override
public final XContentBuilder toXContent(XContentBuilder builder, Params params) throws IOException {
builder.startObject(name);
if(params != null && params.paramAsBoolean("output_type", false)) {
builder.field(CommonFields.TYPE, type().name);
}
if(params != null && params.paramAsBoolean("output_concrete_type", false)) {
builder.field(CommonFields.CONCRETE_TYPE, getClass().getName());
}
doXContentBody(builder, params);
builder.endObject();
return builder;
Expand All @@ -167,6 +173,8 @@ public final XContentBuilder toXContent(XContentBuilder builder, Params params)
*/
public static final class CommonFields {
public static final XContentBuilderString BUCKETS = new XContentBuilderString("buckets");
public static final XContentBuilderString TYPE = new XContentBuilderString("_type");
public static final XContentBuilderString CONCRETE_TYPE = new XContentBuilderString("_concrete_type");
public static final XContentBuilderString VALUE = new XContentBuilderString("value");
public static final XContentBuilderString VALUES = new XContentBuilderString("values");
public static final XContentBuilderString VALUE_AS_STRING = new XContentBuilderString("value_as_string");
Expand Down