[Test] Avoid use the same token name in different tests #74280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywangd
added
>test
|
Pinging @elastic/es-security (Team:Security) |
|
The failure is genuine but not related to my changes. I raised #74282 |
…service-token-name
tvernum
approved these changes
Jun 22, 2021
ywangd
added a commit
to ywangd/elasticsearch
that referenced
this pull request
Jun 22, 2021
The name token1 is used in both testGetServiceAccountCredentials and testCreateServiceAccountToken. There are times when the two tests are not fully isolated. This leads to test failure because indexing of the service token document must be an op_create. This PR fixes the failure by using a different token name in testGetServiceAccountCredentials.
ywangd
added a commit
that referenced
this pull request
Jun 22, 2021
) The name token1 is used in both testGetServiceAccountCredentials and testCreateServiceAccountToken. There are times when the two tests are not fully isolated. This leads to test failure because indexing of the service token document must be an op_create. This PR fixes the failure by using a different token name in testGetServiceAccountCredentials.
ywangd
added a commit
that referenced
this pull request
Jun 22, 2021
ywangd
added a commit
that referenced
this pull request
Jun 22, 2021
ywangd
added a commit
that referenced
this pull request
Jun 22, 2021
ywangd
added a commit
that referenced
this pull request
Jun 22, 2021
ywangd
added a commit
that referenced
this pull request
Jun 23, 2021
ywangd
added a commit
that referenced
this pull request
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name
token1is used in bothtestGetServiceAccountCredentialsandtestCreateServiceAccountToken. There are times when the two tests are not fully isolated. This leads to test failure because indexing of the service token document must be anop_create. This PR fixes the failure by using a different token name intestGetServiceAccountCredentials.Resolves: #74278