ILM mount snapshot step does need to set index.shard.check_on_startup #74283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the Mount API overrides the index.shard.check_on_startup setting value to `false`, there's no need for MountSnapshotStep to set it explicitly.
tlrx
added
>non-issue
:Distributed Coordination/Snapshot/Restore
elasticmachine
added
Team:Data Management
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
Pinging @elastic/es-core-features (Team:Core/Features) |
DaveCTurner
reviewed
Jun 18, 2021
| } else { | ||
| expectedReplicas = 0; | ||
| } | ||
| final String indexCheckOnStartup; |
There was a problem hiding this comment.
I think it'd be better to keep this code and fix the assertion so that we're covering more things:
diff --git a/x-pack/plugin/searchable-snapshots/src/internalClusterTest/java/org/elasticsearch/xpack/searchablesnapshots/FrozenSearchableSnapshotsIntegTests.java b/x-pack/plugin/searchable-snapshots/src/internalClusterTest/java/org/elasticsearch/xpack/searchablesnapshots/FrozenSearchableSnapshotsIntegTests.java
index 5c1688ed1e1..17daeef5895 100644
--- a/x-pack/plugin/searchable-snapshots/src/internalClusterTest/java/org/elasticsearch/xpack/searchablesnapshots/FrozenSearchableSnapshotsIntegTests.java
+++ b/x-pack/plugin/searchable-snapshots/src/internalClusterTest/java/org/elasticsearch/xpack/searchablesnapshots/FrozenSearchableSnapshotsIntegTests.java
@@ -291,7 +291,7 @@ public class FrozenSearchableSnapshotsIntegTests extends BaseFrozenSearchableSna
assertThat(DataTierAllocationDecider.INDEX_ROUTING_PREFER_SETTING.get(settings), equalTo(expectedDataTiersPreference));
assertTrue(SearchableSnapshotsConstants.SNAPSHOT_PARTIAL_SETTING.get(settings));
assertTrue(DiskThresholdDecider.SETTING_IGNORE_DISK_WATERMARKS.get(settings));
- assertThat(IndexSettings.INDEX_CHECK_ON_STARTUP.get(settings), equalTo("false"));
+ assertThat(IndexSettings.INDEX_CHECK_ON_STARTUP.get(settings), equalTo(indexCheckOnStartup));
checkSoftDeletesNotEagerlyLoaded(restoredIndexName);
assertTotalHits(restoredIndexName, originalAllHits, originalBarHits);
|
Thanks David |
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Jun 18, 2021
Now the Mount API overrides the index.shard.check_on_startup setting value to false, there's no need for MountSnapshotStep to set it explicitly. Backport of elastic#74283 Relates elastic#74235
tlrx
added a commit
that referenced
this pull request
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the Mount API overrides the index.shard.check_on_startup
setting value to
false, there's no need for MountSnapshotStepto set it explicitly.
This commit also fixes a failing test where some leftover code
was overriding the setting value.
Relates #74235