-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[DOCS] Fix shrink index API prereqs #84197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It's not actually the case that all the primaries need to be on the same node, replicas are sufficient.
from before the mistaken wording was added.
|
Pinging @elastic/es-docs (Team:Docs) |
|
Pinging @elastic/es-data-management (Team:Data Management) |
jrodewig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this @joegallo. Let me know if you need any help backporting this fix.
|
@jrodewig I backported as far as 7.17 -- do you have tooling to make this easier for the older branches, or are you manually cherry-picking and pushing? Also what's the etiquette on PR labels for those older branches/backports? If it's as simple as "yeah, indeed, add a label for all those versions, then cherry-pick and push" then I can just do that. |
I use the backport tool and temporarily edit .backportrc.json to add the missing branches. Cherry-picking and pushing should work fine too.
We add a label for those versions. |
|
👍, all good, I can handle that then. Thanks! |
It's not actually the case that all the primaries need to be on the same node, replicas are sufficient. I think this got switched to the incorrect wording in #59985 -- so the docs should be fixed back to 7.8 branch if we're doing a completion run.