[7.17] Security plugin close realms (#87429) #87463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Closeable#close` method on `Realm`s was never called upon node shutdown. This is a problem when realms (eg OIDC) create non-daemon threads that expect to be stopped when the `close` method is invoked. Specifically, it is a problem on Windows where the graceful shutdown is implemented by terminatting all non-daemon threads (see `Bootstrap#stop` and `Bootstrap#initializeNatives`). Closes elastic#86286
albertzaharovits
added
>bug
:Security/Security
|
Pinging @elastic/es-security (Team:Security) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Closeable#closemethod onRealms was never called upon nodeshutdown. This is a problem when realms (eg OIDC) create non-daemon
threads that expect to be stopped when the
closemethod is invoked.Specifically, it is a problem on Windows where the graceful shutdown is
implemented by terminatting all non-daemon threads (see
Bootstrap#stopand
Bootstrap#initializeNatives).Backport of #87429
Closes #86286