Skip to content

Fix test testMultiKnnClauses #93047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 25, 2023
Merged

Fix test testMultiKnnClauses #93047

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
77c9a19
Fix multi-clause knn test
benwtrent Jan 18, 2023
6e2580c
Merge remote-tracking branch 'upstream/main' into test/fix-multi-knn-…
benwtrent Jan 24, 2023
ea3c807
ensuring vectors are in separate spaces
benwtrent Jan 24, 2023
164a683
Merge branch 'main' into test/fix-multi-knn-test-case-92940
elasticmachine Jan 24, 2023
4b24afd
Merge branch 'main' into test/fix-multi-knn-test-case-92940
elasticmachine Jan 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions server/src/test/java/org/elasticsearch/action/search/KnnSearchSingleNodeTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,13 +186,13 @@ public void testMultiKnnClauses() throws IOException {
createIndex("index", indexSettings, builder);

for (int doc = 0; doc < 10; doc++) {
client().prepareIndex("index").setSource("vector", randomVector(), "text", "hello world", "number", 1).get();
client().prepareIndex("index").setSource("vector_2", randomVector(), "text", "hello world", "number", 2).get();
client().prepareIndex("index").setSource("vector", randomVector(1.0f, 2.0f), "text", "hello world", "number", 1).get();
client().prepareIndex("index").setSource("vector_2", randomVector(20f, 21f), "text", "hello world", "number", 2).get();
client().prepareIndex("index").setSource("text", "goodnight world", "number", 3).get();
}
client().admin().indices().prepareRefresh("index").get();

float[] queryVector = randomVector();
float[] queryVector = randomVector(20f, 21f);
KnnSearchBuilder knnSearch = new KnnSearchBuilder("vector", queryVector, 5, 50).boost(5.0f);
KnnSearchBuilder knnSearch2 = new KnnSearchBuilder("vector_2", queryVector, 5, 50).boost(10.0f);
SearchResponse response = client().prepareSearch("index")
Expand All @@ -213,7 +213,7 @@ public void testMultiKnnClauses() throws IOException {
assertThat(agg.getAvg(), equalTo(2.25));
assertThat(agg.getSum(), equalTo(45.0));

// Because of the boost, vector_2 results should appear first
// Because of the boost & vector distributions, vector_2 results should appear first
assertNotNull(response.getHits().getAt(0).field("vector_2"));
}

Expand Down Expand Up @@ -372,4 +372,12 @@ private float[] randomVector() {
}
return vector;
}

private float[] randomVector(float dimLower, float dimUpper) {
float[] vector = new float[VECTOR_DIMENSION];
for (int i = 0; i < vector.length; i++) {
vector[i] = (float) randomDoubleBetween(dimLower, dimUpper, true);
}
return vector;
}
}