Simplify watching settings in deciders #93075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idegtiarenko
added
>non-issue
:Distributed Coordination/Allocation
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
fcofdez
added a commit
to fcofdez/elasticsearch
that referenced
this pull request
Jan 25, 2023
After elastic#93075 the first settings parameter in ClusterModule#createAllocationDeciders are expected to be the same settings that ClusterSettings contain, this was not the case for this test and some of the allocator deciders used the default config value instead of the one that the test needed. Closes elastic#93142
fcofdez
added a commit
that referenced
this pull request
Jan 25, 2023
After #93075 the first settings parameter in ClusterModule#createAllocationDeciders are expected to be the same settings that ClusterSettings contain, this was not the case for this test and some of the allocator deciders used the default config value instead of the one that the test needed. Closes #93142
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr simplifies watching for settings changes in allocation deciders and removes unnecessary arguments