Skip to content

Prevent deprecation field usage in SnapshotBasedRecoveryIT #93182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2023
Merged

Prevent deprecation field usage in SnapshotBasedRecoveryIT #93182

merged 1 commit into from
Jan 25, 2023

Conversation

@idegtiarenko
Copy link
Contributor

@idegtiarenko idegtiarenko commented Jan 24, 2023 •
edited
Loading

Related to: #93183

@idegtiarenko idegtiarenko added >test-failure Triaged test failures from CI :Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v8.7.0 labels Jan 24, 2023
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Jan 24, 2023

Pinging @elastic/es-distributed (Team:Distributed)

fcofdez
fcofdez reviewed Jan 24, 2023
View reviewed changes
qa/rolling-upgrade/src/test/java/org/elasticsearch/upgrades/SnapshotBasedRecoveryIT.java
builder.endObject();

Request request = new Request(HttpPost.METHOD_NAME, "/_cluster/reroute?pretty");
Request request = new Request(HttpPost.METHOD_NAME, "/_cluster/reroute?pretty&metric=none");
Copy link
Contributor

@fcofdez fcofdez Jan 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add a comment explaining why we should use that parameter?

Copy link
Contributor

@DaveCTurner DaveCTurner Jan 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relates #92956

fcofdez
fcofdez approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@fcofdez fcofdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@idegtiarenko idegtiarenko merged commit 0ddbd25 into elastic:main Jan 25, 2023
@idegtiarenko idegtiarenko deleted the prevent_deprecation_during_reroute branch January 25, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fcofdez fcofdez fcofdez approved these changes

@DaveCTurner DaveCTurner Awaiting requested review from DaveCTurner

Assignees

No one assigned

Labels

:Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test-failure Triaged test failures from CI v8.7.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@idegtiarenko @elasticsearchmachine @fcofdez @DaveCTurner