Simplify ThreadedActionListener construction
#93184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- There's no real need for the caller's `Logger` just in case an impossible situation happens - we will get enough info from the log message. - Almost nobody uses the `forceExecution` feature, default it to `false`. - Accept an `ExecutorService` rather than requiring the whole `ThreadPool` only to look up the executor later on.
DaveCTurner
added
:Distributed Indexing/Distributed
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
commented
Jan 24, 2023
|
|
||
| @Override | ||
| protected void doExecute(Task task, final Request request, ActionListener<Response> listener) { | ||
| // remove unneeded threading by wrapping listener with SAME to prevent super.doExecute from wrapping it with LISTENER |
|
|
||
| @Override | ||
| protected void doExecute(Task task, final Request request, ActionListener<Response> listener) { | ||
| // remove unneeded threading by wrapping listener with SAME to prevent super.doExecute from wrapping it with LISTENER |
idegtiarenko
approved these changes
Jan 25, 2023
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Jan 26, 2023
Use the new constructor signature for ThreadedActionListener from elastic#93184
arteam
added a commit
that referenced
this pull request
Jan 26, 2023
Use the new constructor signature for ThreadedActionListener from #93184
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 21, 2023
ThreadedActionListener only relies on methods provided by `Executor` but required to pass an `ExecutorService`. With this commit we relax the required type to what's actually needed. Relates #93184
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no real need for the caller's
Loggerjust in case an impossible situation happens - we will get enough info from the log message.Almost nobody uses the
forceExecutionfeature, default it tofalse.Accept an
ExecutorServicerather than requiring the wholeThreadPoolonly to look up the executor later on.