Migrate misc other classes to TransportVersion #93272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
Team:Core/Infra
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
thecoop
commented
Jan 26, 2023
| * This makes sure BWC when introducing a new condition which is not recognized by older versions. | ||
| */ | ||
| boolean includedInVersion(Version version) { | ||
| boolean includedInVersion(TransportVersion version) { |
Member
Author
There was a problem hiding this comment.
I think this is ok to convert, it is certainly only used in a transport context
thecoop
commented
Jan 26, 2023
...a/org/elasticsearch/action/admin/cluster/desirednodes/TransportUpdateDesiredNodesAction.java
Show resolved
Hide resolved
12 tasks
Member
Author
|
@elasticsearchmachine rerun elasticsearch-ci/part-1 |
Member
Author
|
@elasticsearchmachine rerun elasticsearch-ci/bwc |
mark-vieira
pushed a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.