Skip to content

[8.7] Avoid NPE in DiskThresholdMonitor (#93699) #93737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2023
Merged

[8.7] Avoid NPE in DiskThresholdMonitor (#93699) #93737

merged 1 commit into from
Feb 13, 2023
+102 −1

Conversation

@pxsalehi
Copy link
Member

Backports the following commits to 8.7:

@pxsalehi
Avoid NPE in DiskThresholdMonitor (elastic#93699)
1ae7b56 
- Process new ClusterInfo only when the cluster state is recovered, since 
we need to know the indices/nodes in the cluster for this.
- Avoid missing node IDs that could result from a REPLACE shutdown metadata.

Both of these could lead to NPEs which is not fatal in 8.7/8.8, but could lead to 
unresolved listeners on 7.17.
@pxsalehi pxsalehi added :Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) >bug auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. labels Feb 13, 2023
@elasticsearchmachine elasticsearchmachine mentioned this pull request Feb 13, 2023
Merged
@elasticsearchmachine elasticsearchmachine merged commit 68100dd into elastic:8.7 Feb 13, 2023
@pxsalehi pxsalehi deleted the backport/8.7/pr-93699 branch February 13, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport >bug :Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v8.7.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pxsalehi @elasticsearchmachine