Use 1 replica in YAML tests that issue get/exist calls #94303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxsalehi
added
>test
elasticsearchmachine
added
Team:Distributed (Obsolete)
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
Member
Author
|
hmm. Those tests need two nodes at least (they wait for green). Not sure if we can just always use two nodes in the cluster... |
idegtiarenko
approved these changes
Mar 6, 2023
pxsalehi
added a commit
that referenced
this pull request
Mar 6, 2023
We have some YAML tests that would require at least one replica (search shard) to run with Stateless and since they wait for green, they explicitly set replicas to 0 (see e.g. realtime_refresh). Using 2 nodes by default makes sure we could run those tests w/o any changes. IMO, they are pretty important/essential tests. Relates #94303
Member
Author
|
@elasticmachine update branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think for these tests to run in the correct setup in Stateless, there
must be at least one search replica. The only reason they pass now
on Stateless is because we route gets to index shards. With #93976,
these tests would fail. I think they use 0 replicas since the wait for
green. We have to either change this or mute these on Stateless.