Skip to content

Update snyk ci job to use branch as target reference #95794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2023
Merged

Update snyk ci job to use branch as target reference #95794

merged 1 commit into from
May 3, 2023

Conversation

@breskeby
Copy link
Contributor

@breskeby breskeby commented May 3, 2023 •
edited
Loading

We wanna track projects by branch and not by version anymore which makes maintenance of snyk reported issues way easier.

@breskeby breskeby self-assigned this May 3, 2023
@breskeby breskeby added >enhancement :Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team v7.17.11 labels May 3, 2023
@breskeby breskeby marked this pull request as ready for review May 3, 2023 15:19
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

jkakavas
jkakavas approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@jkakavas jkakavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , thanks !

jakelandis
jakelandis approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@jakelandis jakelandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@breskeby breskeby merged commit 68528db into elastic:main May 3, 2023
@breskeby breskeby mentioned this pull request May 3, 2023
Merged
breskeby added a commit to breskeby/elasticsearch that referenced this pull request May 3, 2023
@breskeby
Update snyk ci job to use branch as target reference (elastic#95794)
a1db9dc
@breskeby breskeby mentioned this pull request May 3, 2023
Merged
breskeby added a commit to breskeby/elasticsearch that referenced this pull request May 3, 2023
@breskeby
Update snyk ci job to use branch as target reference (elastic#95794)
aa24026
elasticsearchmachine pushed a commit that referenced this pull request May 3, 2023
@breskeby
Update snyk ci job to use branch as target reference (#95794) (#95801)
44d14c8
elasticsearchmachine pushed a commit that referenced this pull request May 3, 2023
@breskeby
Update snyk ci job to use branch as target reference (#95794) (#95802)
7c1bdf7
breskeby added a commit to breskeby/elasticsearch that referenced this pull request May 3, 2023
@breskeby
Update snyk ci job to use branch as target reference (elastic#95794)
70d1230
breskeby added a commit that referenced this pull request May 3, 2023
@breskeby
Update snyk ci job to use branch as target reference (#95794) (#95805)
311f90e
@breskeby breskeby deleted the update-snyk-target-reference branch December 10, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakelandis jakelandis jakelandis approved these changes

@jkakavas jkakavas jkakavas approved these changes

@mark-vieira mark-vieira Awaiting requested review from mark-vieira

Assignees

@breskeby breskeby

Labels

:Delivery/Build Build or test infrastructure >enhancement Team:Delivery Meta label for Delivery team v7.17.11 v8.7.2 v8.8.0 v8.9.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@breskeby @elasticsearchmachine @jakelandis @jkakavas @bpintea