Skip to content

Conversation

@breskeby
Copy link
Contributor

@breskeby breskeby commented Jun 8, 2023

Keep Gradle wrapper up to date

@breskeby breskeby self-assigned this Jun 8, 2023
@breskeby breskeby added >enhancement :Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team labels Jun 8, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@breskeby breskeby changed the title Update wrapper to 8.2-rc-2 Update Gradle Wrapper to 8.2-rc-2 Jun 8, 2023
@breskeby breskeby force-pushed the gradle-update-82 branch from 2405870 to 62a07bd Compare June 8, 2023 16:57
@breskeby breskeby changed the title Update Gradle Wrapper to 8.2-rc-2 Update Gradle Wrapper to 8.2-rc-3 Jun 28, 2023
@breskeby breskeby changed the title Update Gradle Wrapper to 8.2-rc-3 Update Gradle Wrapper to 8.2 Jul 3, 2023
@breskeby breskeby force-pushed the gradle-update-82 branch from 74b93ac to d2648f2 Compare July 3, 2023 11:46
@breskeby breskeby requested a review from mark-vieira July 3, 2023 16:27
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this required? Does the JavaPlugin no longer apply the BasePlugin?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought of applying it explicitly here as we require the BasePluginExtension in this class. But seems to cause more confusion than clarification. Removed it

@breskeby breskeby force-pushed the gradle-update-82 branch from 148596c to 740f2cd Compare July 4, 2023 10:27
@breskeby breskeby merged commit b862707 into elastic:main Jul 4, 2023
@breskeby breskeby deleted the gradle-update-82 branch July 4, 2023 13:35
breskeby added a commit to breskeby/elasticsearch that referenced this pull request Sep 25, 2023
- Convention usage has been deprecated and was fixed in our build files
- Fix test dependencies and deprecation

(cherry picked from commit b862707)

# Conflicts:
#	build-conventions/build.gradle
#	build-tools-internal/gradle/wrapper/gradle-wrapper.properties
#	build-tools-internal/src/main/resources/minimumGradleVersion
#	build-tools/build.gradle
#	build-tools/reaper/build.gradle
#	build-tools/src/main/java/org/elasticsearch/gradle/plugin/PluginPropertiesExtension.java
#	client/benchmark/build.gradle
#	distribution/tools/ansi-console/build.gradle
#	gradle/build.versions.toml
#	gradle/verification-metadata.xml
#	gradle/wrapper/gradle-wrapper.jar
#	gradle/wrapper/gradle-wrapper.properties
#	libs/x-content/impl/build.gradle
#	plugins/examples/gradle/wrapper/gradle-wrapper.properties
#	x-pack/plugin/ent-search/build.gradle
#	x-pack/plugin/eql/build.gradle
#	x-pack/plugin/old-lucene-versions/build.gradle
#	x-pack/plugin/ql/build.gradle
#	x-pack/plugin/redact/build.gradle
#	x-pack/plugin/snapshot-based-recoveries/build.gradle
#	x-pack/plugin/stack/build.gradle
#	x-pack/plugin/write-load-forecaster/build.gradle
breskeby added a commit that referenced this pull request Sep 27, 2023
* Update Gradle Wrapper to 8.2 (#96686)

- Convention usage has been deprecated and was fixed in our build files
- Fix test dependencies and deprecation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Delivery/Build Build or test infrastructure >enhancement Team:Delivery Meta label for Delivery team v8.10.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants