Dry up some spots around map reading from StreamInput #96853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly the keys we read are strings, lets add an overload for that to save some code and maybe help the compiler make better decisions. Also readMapOfLists an be way simplified, no point in duplicating the map reading code here just to save one capturing lambda, there's not hot code that benefits from this.
original-brownbear
added
>non-issue
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
arteam
approved these changes
Jun 15, 2023
Contributor
arteam
left a comment
arteam
left a comment
There was a problem hiding this comment.
LGTM! That indeed looks much terser.
Contributor
Author
|
Thanks Artem! |
| } | ||
| return map; | ||
| public <V> Map<String, List<V>> readMapOfLists(final Writeable.Reader<V> valueReader) throws IOException { | ||
| return readMap(i -> i.readList(valueReader)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly the keys we read are strings, lets add an overload for that to save some code and maybe help the compiler make better decisions. Also readMapOfLists an be way simplified, no point in duplicating the map reading code here just to save one capturing lambda, there's not hot code that benefits from this.