-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Add transport version to main response #96900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
elasticsearchmachine
merged 6 commits into
elastic:main
from
rjernst:transport_versions/inform
Jun 20, 2023
Merged
Add transport version to main response #96900
elasticsearchmachine
merged 6 commits into
elastic:main
from
rjernst:transport_versions/inform
Jun 20, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The root endpoint for Elasticsearch contains diagnostic information about what Elasticsearch is running. This commit adds TransportVersion to this diagnostic information, alongside the existing version information.
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
thecoop
reviewed
Jun 19, 2023
modules/rest-root/src/main/java/org/elasticsearch/rest/root/MainResponse.java
Show resolved
Hide resolved
pgomulka
approved these changes
Jun 19, 2023
Contributor
pgomulka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
modules/rest-root/src/main/java/org/elasticsearch/rest/root/MainResponse.java
Show resolved
Hide resolved
thecoop
approved these changes
Jun 20, 2023
Member
Author
|
@elasticsearchmachine run elasticsearch-ci/part-1 |
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Jun 21, 2023
In elastic#96900 a new transport version was added for additional information in the main response. However, due to upstream conflicts, this transport version had to be bumped a few times. In the process, the the version was bumped, but the condition was never updated. This commit fixes the condition to use the version that was added.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 21, 2023
In #96900 a new transport version was added for additional information in the main response. However, due to upstream conflicts, this transport version had to be bumped a few times. In the process, the the version was bumped, but the condition was never updated. This commit fixes the condition to use the version that was added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
:Core/Infra/Core
Core issues without another label
>refactoring
Team:Core/Infra
Meta label for core/infra team
v8.9.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root endpoint for Elasticsearch contains diagnostic information about what Elasticsearch is running. This commit adds TransportVersion to this diagnostic information, alongside the existing version information.