Track total task execution time in TaskExecutionTimeTrackingEsThreadPoolExecutor #96944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxsalehi
force-pushed
the
ps230620-trackTotalExecTimeInExecutor
branch
2 times, most recently
from
b49aa47 to
3226f32
Compare
pxsalehi
force-pushed
the
ps230620-trackTotalExecTimeInExecutor
branch
from
3226f32 to
e486e17
Compare
pxsalehi
commented
Jun 20, 2023
| * An extension to thread pool executor, which tracks statistics for the task execution time. | ||
| */ | ||
| public final class EWMATrackingEsThreadPoolExecutor extends EsThreadPoolExecutor { | ||
| public final class TaskExecutionTimeTrackingEsThreadPoolExecutor extends EsThreadPoolExecutor { |
Member
Author
There was a problem hiding this comment.
The names a bit verbose/long, but we rarely use it directly. I'm open for suggestions.
Contributor
There was a problem hiding this comment.
It follows the venerable Java naming tradition, it's good 😅
pxsalehi
added
>non-issue
:Distributed Indexing/Distributed
pxsalehi
commented
Jun 20, 2023
| if (taskExecutionNanos != -1) { | ||
| // taskExecutionNanos may be -1 if the task threw an exception | ||
| executionEWMA.addValue(taskExecutionNanos); | ||
| totalExecutionTime.add(taskExecutionNanos); |
Member
Author
There was a problem hiding this comment.
I've kept this as nano (rather than millis). I think it is safe.
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
fcofdez
approved these changes
Jun 20, 2023
Contributor
fcofdez
left a comment
fcofdez
left a comment
There was a problem hiding this comment.
LGTM, I left a couple of minor nits around tests
| assertThat(executor.getTotalTaskExecutionTime(), equalTo(0L)); | ||
| executeTask(executor, 1); | ||
| assertBusy(() -> { assertThat((long) executor.getTaskExecutionEWMA(), equalTo(30L)); }); | ||
| assertBusy(() -> { |
Contributor
There was a problem hiding this comment.
nit: could we add a comment to note that fastWrapper makes each execution look like it took 100ns?
|
|
||
| assertThat((long) executor.getTaskExecutionEWMA(), equalTo(0L)); | ||
| executeTask(executor, 1); | ||
| int taskCount = randomIntBetween(1, 100); |
Contributor
There was a problem hiding this comment.
nit: same as above, could we add a comment regarding exceptionalWrapper?
| * An extension to thread pool executor, which tracks statistics for the task execution time. | ||
| */ | ||
| public final class EWMATrackingEsThreadPoolExecutor extends EsThreadPoolExecutor { | ||
| public final class TaskExecutionTimeTrackingEsThreadPoolExecutor extends EsThreadPoolExecutor { |
Contributor
There was a problem hiding this comment.
It follows the venerable Java naming tradition, it's good 😅
pxsalehi
added
the
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Track total task execution time in EWMATrackingEsThreadPoolExecutor and rename it.
Relates ES-6249