[Profiling] Use descriptive name for ILM policy #96969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we rename the default ILM policy for profiling from `profiling` to `profiling-60-days` which describes the policy's intention and allows to add related policies in the future more naturally.
danielmitterdorfer
added
>non-issue
v8.9.0
:UniversalProfiling/Application
Collaborator
|
Pinging @elastic/profiling (Team:Universal Profiling) |
rockdaboot
approved these changes
Jun 21, 2023
Contributor
rockdaboot
left a comment
rockdaboot
left a comment
There was a problem hiding this comment.
LGTM
Just a nit: The string "profiling-60-days" appears in at least 4 places. Does it make sense to have a constant for it ?
Member
Author
Good catch; I checked the usages: One of them is referring to the file name of the ILM definition (wouldn't use the constant for that one), one defines the actual ILM policy name and two usages are in tests. I'd probably keep it as is for now also to have the code in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we rename the default ILM policy for profiling from
profilingtoprofiling-60-dayswhich describes the policy's intention and allows to add related policies in the future more naturally.