Skip to content

Use TaskExecutionTimeTrackingEsThreadPoolExecutor for system writes #96971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 21, 2023
Merged

Use TaskExecutionTimeTrackingEsThreadPoolExecutor for system writes #96971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e486e17
Track total task execution time in threadpool
pxsalehi Jun 20, 2023
a768223
Merge remote-tracking branch 'upstream/main' into ps230620-trackTotal…
pxsalehi Jun 21, 2023
a356400
address review comments
pxsalehi Jun 21, 2023
d18c403
Use TaskExecutionTimeTrackingEsThreadPoolExecutor for system write
pxsalehi Jun 21, 2023
a0c40a5
Merge remote-tracking branch 'upstream/main' into ps230621-changeSyst…
pxsalehi Jun 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions server/src/main/java/org/elasticsearch/threadpool/ThreadPool.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,14 +234,14 @@ public ThreadPool(final Settings settings, final ExecutorBuilder<?>... customBui
new ScalingExecutorBuilder(Names.FETCH_SHARD_STORE, 1, 2 * allocatedProcessors, TimeValue.timeValueMinutes(5), false)
);
builders.put(Names.SYSTEM_READ, new FixedExecutorBuilder(settings, Names.SYSTEM_READ, halfProcMaxAt5, 2000, false));
builders.put(Names.SYSTEM_WRITE, new FixedExecutorBuilder(settings, Names.SYSTEM_WRITE, halfProcMaxAt5, 1000, false));
builders.put(Names.SYSTEM_WRITE, new FixedExecutorBuilder(settings, Names.SYSTEM_WRITE, halfProcMaxAt5, 1000, true));
builders.put(
Names.SYSTEM_CRITICAL_READ,
new FixedExecutorBuilder(settings, Names.SYSTEM_CRITICAL_READ, halfProcMaxAt5, 2000, false)
);
builders.put(
Names.SYSTEM_CRITICAL_WRITE,
new FixedExecutorBuilder(settings, Names.SYSTEM_CRITICAL_WRITE, halfProcMaxAt5, 1500, false)
new FixedExecutorBuilder(settings, Names.SYSTEM_CRITICAL_WRITE, halfProcMaxAt5, 1500, true)
);

for (final ExecutorBuilder<?> builder : customBuilders) {
Expand Down
5 changes: 5 additions & 0 deletions server/src/test/java/org/elasticsearch/threadpool/ThreadPoolTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,6 +355,11 @@ public void testWriteThreadPoolUsesTaskExecutionTimeTrackingEsThreadPoolExecutor
final ThreadPool threadPool = new TestThreadPool("test", Settings.EMPTY);
try {
assertThat(threadPool.executor(ThreadPool.Names.WRITE), instanceOf(TaskExecutionTimeTrackingEsThreadPoolExecutor.class));
assertThat(threadPool.executor(ThreadPool.Names.SYSTEM_WRITE), instanceOf(TaskExecutionTimeTrackingEsThreadPoolExecutor.class));
assertThat(
threadPool.executor(ThreadPool.Names.SYSTEM_CRITICAL_WRITE),
instanceOf(TaskExecutionTimeTrackingEsThreadPoolExecutor.class)
);
} finally {
assertTrue(terminate(threadPool));
}
Expand Down