Skip to content

[DOCS] Add link to Render Search Application Query docs #97067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2023
Merged

[DOCS] Add link to Render Search Application Query docs #97067

merged 1 commit into from
Jun 24, 2023

Conversation

@abdonpijpelink
Copy link
Contributor

@abdonpijpelink abdonpijpelink commented Jun 24, 2023

The docs for Render Search Application Query were added in #95513, but not included in index.asciidoc, so they're not actually part of the documentation. This PR includes the page, because its omission is causing docs build errors:

10:45:13 INFO:build_docs:Bad cross-document links:
10:45:13 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/elasticsearch/client/javascript-api/8.9/api-reference.html contains broken links to:
10:45:13 INFO:build_docs:   - en/elasticsearch/reference/8.9/search-application-render-query.html

@abdonpijpelink abdonpijpelink added >docs General docs changes :EnterpriseSearch/Application Enterprise Search v8.9.1 labels Jun 24, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 24, 2023

Documentation preview:

@elasticsearchmachine elasticsearchmachine added v8.10.0 Team:Docs Meta label for docs team Team:Enterprise Search Meta label for Enterprise Search team labels Jun 24, 2023
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Jun 24, 2023

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Jun 24, 2023

Pinging @elastic/ent-search-eng (Team:Enterprise Search)

kilfoyle
kilfoyle approved these changes Jun 24, 2023
View reviewed changes
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I'm out of my depth with these API docs but I'll approve to help us get the build fixed up.

Thanks for pushing this @abdonpijpelink!

@abdonpijpelink abdonpijpelink merged commit 012dea5 into elastic:main Jun 24, 2023
@abdonpijpelink abdonpijpelink deleted the docs-render-query branch June 24, 2023 10:03
@abdonpijpelink abdonpijpelink mentioned this pull request Jun 24, 2023
Merged
@abdonpijpelink
Copy link
Contributor Author

abdonpijpelink commented Jun 24, 2023

💚 All backports created successfully

Status Branch Result
✅ 8.9

Questions ?

Please refer to the Backport tool documentation

abdonpijpelink added a commit to abdonpijpelink/elasticsearch that referenced this pull request Jun 24, 2023
@abdonpijpelink
[DOCS] Add link to Render Search Application Query docs (elastic#97067)
bef6168 
(cherry picked from commit 012dea5)
elasticsearchmachine pushed a commit that referenced this pull request Jun 24, 2023
@abdonpijpelink
[DOCS] Add link to Render Search Application Query docs (#97067) (#97068
2f8efae 
)

(cherry picked from commit 012dea5)
@leemthompo leemthompo mentioned this pull request Jun 26, 2023
Merged
@rjernst rjernst added v8.9.0 and removed v8.9.1 labels Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kilfoyle kilfoyle kilfoyle approved these changes

Assignees

No one assigned

Labels

>docs General docs changes :EnterpriseSearch/Application Enterprise Search Team:Docs Meta label for docs team Team:Enterprise Search Meta label for Enterprise Search team v8.9.0 v8.10.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@abdonpijpelink @elasticsearchmachine @kilfoyle @rjernst