Skip to content

Conversation

@jrmolin
Copy link
Contributor

@jrmolin jrmolin commented Nov 21, 2025

Proposed commit message

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • [ ] I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Nov 21, 2025

🚀 Benchmarks report

Package m365_defender 👍(4) 💚(1) 💔(3)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
incident 1067.24 822.03 -245.21 (-22.98%) 💔
vulnerability 10204.08 6357.28 -3846.8 (-37.7%) 💔
vulnerability 10204.08 6535.95 -3668.13 (-35.95%) 💔

Package o365 👍(1) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
audit 2159.83 1483.68 -676.15 (-31.31%) 💔

To see the full report comment with /test benchmark fullreport

@jrmolin jrmolin marked this pull request as ready for review November 25, 2025 14:08
@jrmolin jrmolin requested a review from a team as a code owner November 25, 2025 14:08
@andrewkroh andrewkroh added the Team:Elastic-Agent Platform - Ingest - Agent [elastic/elastic-agent] label Nov 25, 2025
@elasticmachine
Copy link

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@andrewkroh andrewkroh added the enhancement New feature or request label Nov 25, 2025
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] label Dec 1, 2025
@elasticmachine
Copy link

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@jrmolin jrmolin requested a review from a team as a code owner December 3, 2025 16:02
@elasticmachine
Copy link

elasticmachine commented Dec 3, 2025

💔 Build Failed

Failed CI Steps

History

cleanup() {
echo "Deleting temporary files..."
rm -rf ${WORKSPACE}/${TMP_FOLDER_TEMPLATE_BASE}.*
rm -rf ${WORKSPACE}/${TMP_FOLDER_TEMPLATE_BASE:-tmp}.*
Copy link
Collaborator

@mrodm mrodm Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that this was added because of this error:
https://buildkite.com/elastic/integrations/builds/34885#019adb5a-c571-4e28-86c2-10296b72dde4/112-114

This happens because post-checkout hook failed (due to merge conflicts) and the .buildkite/hooks/pre-command hook was not executed. Once these merge conflicts with the target branch are solved, this failure should disappear.

That variable is set in the pre-command hook and I was supposed to have value in the pre-exit hook too, but this is not the case if post-checkout fails:

REPO_NAME=$(repo_name "${BUILDKITE_REPO}")
export REPO_NAME
export TMP_FOLDER_TEMPLATE_BASE="tmp.${REPO_NAME}"

Looking at the current usages of these variables, I think those variables can be removed completely @jrmolin
You can revert this change, and I'll create a PR to remove those variables. Thereby, this PR just modifies elastic_agent package (so no need to test all the other packages in the repo).

Copy link
Collaborator

@mrodm mrodm Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created PR for that @jrmolin , I think you can revert that change in favor of the changes in #16233

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jrmolin
#16233 has been merged, so those variables have been removed.
You would need to update your branch and solve the conflicts (sorry 😅 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:elastic_agent Elastic Agent Team:Elastic-Agent Platform - Ingest - Agent [elastic/elastic-agent] Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants