-
Notifications
You must be signed in to change notification settings - Fork 519
add log.* mapping for elastic-agent #16083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
incident |
1067.24 | 822.03 | -245.21 (-22.98%) | 💔 |
vulnerability |
10204.08 | 6357.28 | -3846.8 (-37.7%) | 💔 |
vulnerability |
10204.08 | 6535.95 | -3668.13 (-35.95%) | 💔 |
Package o365 👍(1) 💚(0) 💔(1)
Expand to view
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
audit |
2159.83 | 1483.68 | -676.15 (-31.31%) | 💔 |
To see the full report comment with /test benchmark fullreport
|
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
💔 Build Failed
Failed CI StepsHistory
|
| cleanup() { | ||
| echo "Deleting temporary files..." | ||
| rm -rf ${WORKSPACE}/${TMP_FOLDER_TEMPLATE_BASE}.* | ||
| rm -rf ${WORKSPACE}/${TMP_FOLDER_TEMPLATE_BASE:-tmp}.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that this was added because of this error:
https://buildkite.com/elastic/integrations/builds/34885#019adb5a-c571-4e28-86c2-10296b72dde4/112-114
This happens because post-checkout hook failed (due to merge conflicts) and the .buildkite/hooks/pre-command hook was not executed. Once these merge conflicts with the target branch are solved, this failure should disappear.
That variable is set in the pre-command hook and I was supposed to have value in the pre-exit hook too, but this is not the case if post-checkout fails:
integrations/.buildkite/hooks/pre-command
Lines 25 to 28 in bb632b7
| REPO_NAME=$(repo_name "${BUILDKITE_REPO}") | |
| export REPO_NAME | |
| export TMP_FOLDER_TEMPLATE_BASE="tmp.${REPO_NAME}" |
Looking at the current usages of these variables, I think those variables can be removed completely @jrmolin
You can revert this change, and I'll create a PR to remove those variables. Thereby, this PR just modifies elastic_agent package (so no need to test all the other packages in the repo).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposed commit message
Checklist
changelog.ymlfile.[ ] I have verified that any added dashboard complies with Kibana's Dashboard good practicesAuthor's Checklist
How to test this PR locally
Related issues
Screenshots