Skip to content

Conversation

@djptek
Copy link
Contributor

@djptek djptek commented Sep 7, 2022

What does this PR do?

This PR will validate system testing through the addition of an assertion for expected number of events

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
    - [ ] I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
    - [ ] I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

How to test this PR locally

Ensure elastic-package is up to date by running

make install

in the ./elastic-package root directory of an up-to-date clone or synced fork of this repository

In the integrations repository, run the following commands from the ./integrations root directory

cd ../httpjson
elastic-package stack down -v
elastic-package build -v
elastic-package stack up --version 8.5.0-SNAPSHOT -v -d
elastic-package test system -v

Validate that the output contains:

  • Debug entries similar to the following:
2022/11/22 20:12:47 DEBUG running test with configuration 'expected-event-count'
2022/11/22 20:12:47 DEBUG setting up service...
...
2022/11/22 20:13:07 DEBUG checking for expected data in data stream...
2022/11/22 20:13:07 DEBUG found 1 hits in logs-httpjson.generic-ep data stream
2022/11/22 20:13:07 DEBUG found 3 events under "parent"

(The assertion found 3 events under "parent" will only triggered after the related elastic-package PR has merged)

  • A Test result similar to the following:

    │ httpjson │ generic │ system │ expected-event-count │ PASS │ 20.829026099s │

Related issues

## Screenshots

@djptek djptek added the enhancement New feature or request label Sep 7, 2022
@djptek djptek changed the title [system testing] Add assertion for expected number of events [system testing] Validate assertion for expected number of events Sep 7, 2022
@elasticmachine
Copy link

elasticmachine commented Sep 7, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-23T15:49:28.906+0000

  • Duration: 17 min 53 sec

Test stats 🧪

Test Results
Failed 0
Passed 8
Skipped 0
Total 8

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@djptek djptek self-assigned this Sep 8, 2022
@elasticmachine
Copy link

elasticmachine commented Sep 12, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 1.705
Classes 100.0% (0/0) 💚 1.705
Methods 100.0% (3/3) 💚 8.6
Lines 100.0% (0/0) 💚 7.11
Conditionals 100.0% (0/0) 💚

@botelastic
Copy link

botelastic bot commented Oct 20, 2022

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Oct 20, 2022
@botelastic botelastic bot removed the Stalled label Oct 27, 2022
@djptek djptek marked this pull request as ready for review November 22, 2022 19:47
@djptek djptek requested a review from a team as a code owner November 22, 2022 19:47
@botelastic
Copy link

botelastic bot commented Jan 22, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Jan 22, 2023
@ebeahan ebeahan closed this Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Stalled

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants